[jira] [Commented] (YARN-9997) Code cleanup in ZKConfigurationStore

["Andras Gyori (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089744#comment-17089744 ] 

Andras Gyori commented on YARN-9997:
------------------------------------

As YARN-10002 had been successfully backported, I have uploaded the backport patch as well.

> Code cleanup in ZKConfigurationStore
> ------------------------------------
>
>                 Key: YARN-9997
>                 URL: https://issues.apache.org/jira/browse/YARN-9997
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Andras Gyori
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: YARN-9997.001.patch, YARN-9997.002.patch, YARN-9997.003.patch, YARN-9997.004.patch, YARN-9997.005.patch, YARN-9997.006.patch, YARN-9997.branch-3.2.001.patch
>
>
> Many thins can be improved:
> * znodeParentPath could be a local variable
> * zkManager could be private, VisibleForTesting annotation is not needed anymore
> * Do something with unchecked casts
> * zkManager.safeSetData calls are almost having the same set of parameters: Simplify this
> * Extract zkManager calls to their own methods: They are repeated
> * Remove TODOs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org