[GitHub] [zeppelin] florpor opened a new pull request #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden

[GitBox <gi...@apache.org>]

florpor opened a new pull request #3363: [ZEPPELIN-4144] After refresh the revision tools are sometimes hidden
URL: https://github.com/apache/zeppelin/pull/3363
 
 
   ### What is this PR for?
   Fixes issue where after refreshing a note's page the revision controls in the navigation bar are hidden since listConfigurations is only requested in the navbar controller after a loginSuccess broadcast.
   This currently works sometimes because another controller (note-import) sends a listConfigurations request when it is loaded and navbar controller is sometimes loaded by the time the response arrives, but I can reproduce it easily using Firefox (gif attached to Jira issue).
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   
   ### What is the Jira issue?
   [https://issues.apache.org/jira/browse/ZEPPELIN-4144](https://issues.apache.org/jira/browse/ZEPPELIN-4144)
   
   ### How should this be tested?
   Added unit and e2e tests to make sure listConfigurations is called and controls are visible.
   Seems to me like the issue is easier to reproduce using Firefox. Was able to do so using the official 0.8.1 docker image.
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services