You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/10/29 18:56:33 UTC
[jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Thanks to @andreaturli for kicking this off in PR #22
This isn't ready yet but I wanted to seek comments on the TargetPoolApi and associated TargetPoolCreationOptions.
There is redundancy between the TargetPoolCreationOptions and the TargetPool resource class. I have taken the rout of having a separate class with redundant code. Happy to change, what do people think?
I plan to do the same thing for the ForwardingRuleApi
You can merge this Pull Request by running:
git pull https://github.com/danbroudy/jclouds-labs-google loadbalancer
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/69
-- Commit Summary --
* initial commit to support GCE LB
* address comments to PR #22
* address most of the comments for PR22
* fix compilation errors
* minor updates and expect test changes
* sqitching back to Objects from MoreObjects
* Revamped TargetPoolApi and expect test. Missing getHealth, aggregated list and LiveTests need work
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApi.java (72)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/TargetPoolChangeHealthChecksBinder.java (33)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/TargetPoolChangeInstancesBinder.java (33)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/TargetPoolCreationBinder.java (75)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/binders/TargetPoolMapofSetofMapGenericBinder.java (64)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java (6)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (37)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (4)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java (34)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroup.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/loaders/FindNetworkOrCreate.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (7)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/UseNodeCredentialsButOverrideFromTemplate.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineParserModule.java (47)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AbstractDisk.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Address.java (11)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Disk.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Firewall.java (3)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ForwardingRule.java (198)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/HttpHealthCheck.java (235)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Image.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/MachineType.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Network.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Operation.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Project.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Quota.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Region.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Resource.java (25)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Route.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Snapshot.java (6)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/TargetPool.java (237)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Zone.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/AddressApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/FirewallApi.java (3)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApi.java (197)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/GlobalOperationApi.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApi.java (160)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ImageApi.java (3)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/MachineTypeApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/NetworkApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ProjectApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RegionApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RegionOperationApi.java (4)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/RouteApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/SnapshotApi.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetPoolApi.java (242)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ZoneApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ZoneOperationApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/CreateNetworkIfNeeded.java (12)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseAddresses.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseDiskTypes.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseDisks.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseFirewalls.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseForwardingRules.java (65)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseGlobalOperations.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseHttpHealthChecks.java (64)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseImages.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseInstances.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseMachineTypes.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseNetworks.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseRegionOperations.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseRegions.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseRoutes.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseSnapshots.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseTargetPools.java (66)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseZoneOperations.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseZones.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/FirewallOptions.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/ListOptions.java (17)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/RouteOptions.java (2)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/TargetPoolCreationOptions.java (151)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/predicates/GlobalOperationDonePredicate.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/predicates/RegionOperationDonePredicate.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/predicates/ZoneOperationDonePredicate.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/PageSystemExpectTest.java (4)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/TargetPoolAddInstanceBinderTest.java (75)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/binders/TargetPoolCreationBinderTest.java (84)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/NetworkToSecurityGroupTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/loaders/FindNetworkOrCreateTest.java (10)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AddressApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/AddressApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiExpectTest.java (22)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiExpectTest.java (18)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiLiveTest.java (8)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiExpectTest.java (169)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiLiveTest.java (87)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalOperationApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalOperationApiLiveTest.java (4)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiExpectTest.java (179)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java (60)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiExpectTest.java (16)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiLiveTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiExpectTest.java (38)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (24)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/MachineTypeApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/MachineTypeApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiLiveTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RouteApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RouteApiLiveTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/SnapshotApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/SnapshotApiLiveTest.java (4)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiExpectTest.java (322)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java (63)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiLiveTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/functions/CreateNetworkIfNeededTest.java (16)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineApiLiveTest.java (9)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseForwardingRuleListTest.java (59)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseForwardingRuleTest.java (51)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java (82)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckTest.java (53)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionOperationTest.java (55)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseTargetPoolListTest.java (54)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseTargetPoolTest.java (48)
A google-compute-engine/src/test/resources/forwardingrule_get.json (12)
A google-compute-engine/src/test/resources/forwardingrule_insert.json (4)
A google-compute-engine/src/test/resources/forwardingrule_list.json (19)
A google-compute-engine/src/test/resources/httphealthcheck_get.json (7)
A google-compute-engine/src/test/resources/httphealthcheck_insert.json (1)
A google-compute-engine/src/test/resources/httphealthcheck_list.json (32)
A google-compute-engine/src/test/resources/targetpool_addinstance.json (1)
A google-compute-engine/src/test/resources/targetpool_changehealthcheck.json (1)
A google-compute-engine/src/test/resources/targetpool_get.json (9)
A google-compute-engine/src/test/resources/targetpool_insert.json (3)
A google-compute-engine/src/test/resources/targetpool_list.json (17)
A google-compute-engine/src/test/resources/targetpool_setbackup.json (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/69.patch
https://github.com/jclouds/jclouds-labs-google/pull/69.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1592](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1592/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61140848
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by danbroudy <no...@github.com>.
I would also be fine to take measures to decrease the size of this commit by removing renames and comment edits. Many were done in response to comments in #22 but they significantly increase the number of effected files.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-60973072
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #189](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/189/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61030663
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #190](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/190/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61033161
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by Andrea Turli <no...@github.com>.
Thanks @danbroudy for helping us close that!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61310875
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1582](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1582/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61033413
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #195](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/195/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61139267
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #188](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/188/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-60972957
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by Adrian Cole <no...@github.com>.
> +import com.google.common.annotations.Beta;
> +import com.google.common.base.Objects;
> +import com.google.common.base.Optional;
> +
> +import java.beans.ConstructorProperties;
> +import java.net.URI;
> +import java.util.Date;
> +
> +import static com.google.common.base.Objects.equal;
> +import static com.google.common.base.Optional.fromNullable;
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> +import org.jclouds.javax.annotation.Nullable;
> +
> +@Beta
> +public class ForwardingRule extends Resource {
note: you'll want to stop extending resource as we are switching to flat value types. I can help fix this later, if you don't want to do that now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69/files#r19588783
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by Adrian Cole <no...@github.com>.
I'll probably help @nacx convert this project to auto value and simplify a lot of the serialization logic. As this pull request is put together now, provided live tests work, etc. I'm ok merging. Should be squashed, though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61048875
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1591](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1591/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61139768
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1576](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1576/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-60973763
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by Adrian Cole <no...@github.com>.
Closed #69.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#event-186337335
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #194](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/194/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61138953
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1580](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1580/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61030979
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by Adrian Cole <no...@github.com>.
merged to master. Thanks tons!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61203612
Re: [jclouds-labs-google] GCE Loadbalancer Continuation (#69)
Posted by danbroudy <no...@github.com>.
On the master branch before these changes there are currently 4 live test failures when I run them.
I am experiencing the same 4 failures when I run the tests with this PRs changes.
These test failures are also nothing new. I reported them on the JIRA at [JCLOUDS-755](https://issues.apache.org/jira/browse/JCLOUDS-755)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/69#issuecomment-61179989