[GitHub] [arrow-datafusion] alamb commented on issue #6577: Why exclude datafusion-cli from workspace?

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on issue #6577:
URL: https://github.com/apache/arrow-datafusion/issues/6577#issuecomment-1580621024

   > The current test bug of datafusion-cli has been fixed in https://github.com/apache/arrow-datafusion/pull/6576 .
   
   Thank you!
   
   > But should we add datafusion-cli to workspace to guarantee that the tests are covered？
   
   There were reasons (related to publishing datafusion-cli as a package -- https://github.com/apache/arrow-datafusion/issues/2071  -- as I remember 🤔 ) for not putting it i the workspace. 
   
   I think we could run the datafusion-cli tests by adding a specific CI job that ran them, like:
   ```shell
   cd datafusion/datafusion-cli
   cargo test --all-features
   ```
   
   What do you think @r4ntix ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org