You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 11:24:10 UTC
[GitHub] [arrow] assignUser commented on a diff in pull request #13350: ARROW-16793: [CI] Update tags for M1 self-hosted runner jobs to be more specific
assignUser commented on code in PR #13350:
URL: https://github.com/apache/arrow/pull/13350#discussion_r893370142
##########
dev/tasks/verify-rc/github.macos.arm64.yml:
##########
@@ -22,7 +22,7 @@
jobs:
verify:
name: "Verify release candidate on macOS"
- runs-on: {{ github_runner|default("self-hosted") }}
+ runs-on: {{ github_runner|default(["self-hosted", "macOS", "arm64"]) }}
Review Comment:
```suggestion
runs-on: {{ github_runner|default('["self-hosted", "macOS", "arm64"]') }}
```
Should this not be quoted to be inserted verbatim?
##########
dev/tasks/verify-rc/github.macos.arm64.yml:
##########
@@ -22,7 +22,7 @@
jobs:
verify:
name: "Verify release candidate on macOS"
- runs-on: {{ github_runner|default("self-hosted") }}
+ runs-on: {{ github_runner|default(["self-hosted", "macOS", "arm64"]) }}
Review Comment:
Looks like it isn't strictly necessary
##########
dev/tasks/tasks.yml:
##########
@@ -1040,7 +1040,7 @@ tasks:
TEST_INTEGRATION_JAVA: 0
PYTEST_ADDOPTS: "-k 'not test_cancellation'"
target: {{ target }}
- github_runner: "self-hosted"
+ runs-on: ["self-hosted", "macOS", "arm64"]
Review Comment:
You renamed the param here, I guess that did not error because the template has a default.
```suggestion
github_runner: '["self-hosted", "macOS", "arm64"]'
```
##########
dev/tasks/tasks.yml:
##########
@@ -1067,7 +1067,7 @@ tasks:
params:
env:
PYTEST_ADDOPTS: "-k 'not test_cancellation'"
- github_runner: "self-hosted"
+ runs-on: ["self-hosted", "macOS", "arm64"]
Review Comment:
Same here
```suggestion
github_runner: '["self-hosted", "macOS", "arm64"]'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org