You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/12/03 16:03:00 UTC
[jira] [Work logged] (LANG-1622) Javadoc of some methods
incorrectly refers to another method
[ https://issues.apache.org/jira/browse/LANG-1622?focusedWorklogId=519756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-519756 ]
ASF GitHub Bot logged work on LANG-1622:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/20 16:02
Start Date: 03/Dec/20 16:02
Worklog Time Spent: 10m
Work Description: kanaksony commented on a change in pull request #667:
URL: https://github.com/apache/commons-lang/pull/667#discussion_r535364671
##########
File path: src/main/java/org/apache/commons/lang3/BooleanUtils.java
##########
@@ -548,9 +548,9 @@ public static Boolean toBooleanObject(final int value, final int trueValue, fina
* if unboxed to a {@code boolean}.</p>
*
* <pre>
- * BooleanUtils.toBoolean(Integer.valueOf(0)) = Boolean.FALSE
Review comment:
@garydgregory I understand you merged PR 668 as it was reported by original reporter and had fix too. If you will review my PR, I have corrected similar issue thing on other lines too that's from L551-L553.
Should I make another PR for same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 519756)
Time Spent: 50m (was: 40m)
> Javadoc of some methods incorrectly refers to another method
> ------------------------------------------------------------
>
> Key: LANG-1622
> URL: https://issues.apache.org/jira/browse/LANG-1622
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
> Affects Versions: 3.11
> Reporter: Ludek
> Priority: Trivial
> Labels: StringUtils
> Fix For: 3.12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> two examples in javadoc of StringUtils.isNumericSpace incorrectly refer to {color:#172b4d}isNumeric{color}
>
> {color:#808080}* StringUtils.isNumeric("\u0967\u0968\u0969") = true{color}{color:#808080}* StringUtils.isNumeric("\u0967\u0968 \u0969") = true{color}
> {color:#ff00dc} {color}
> {color:#172b4d}and same for BooleanUtils.toBoolean{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)