You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/14 06:50:14 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #539: More Bug fixes
davidjumani opened a new pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539
Fixes :
- Fix button name in VM deployment form in its network section to "Create New Network"
- Don't allow users in UI to delete/archive events
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664153279
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664157512
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/539 (JID-2653)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664190544
@rhtyd Done!
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664153117
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#discussion_r460667451
##########
File path: src/components/header/ProjectMenu.vue
##########
@@ -39,7 +39,7 @@
</a-tooltip>
<a-select-option v-for="(project, index) in projects" :key="index">
- {{ project.displaytext || project.name }}
+ {{ project.name }}
Review comment:
Fixed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #539: [WIP] More Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664111525
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #539: [WIP] More Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664111331
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664176062
on refresh/merge conflicts seen - @davidjumani can you fix conflicts against latest master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #539: [WIP] More Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664113342
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/539 (JID-2648)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#discussion_r460650153
##########
File path: src/components/header/ProjectMenu.vue
##########
@@ -39,7 +39,7 @@
</a-tooltip>
<a-select-option v-for="(project, index) in projects" :key="index">
- {{ project.displaytext || project.name }}
+ {{ project.name }}
Review comment:
@davidjumani check against old UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664175821
Merging this to unblock testing @davidjumani pl start another PR if new issues or regressions are seen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#discussion_r460714931
##########
File path: src/config/section/event.js
##########
@@ -44,7 +44,9 @@ export default {
ids: {
value: (record) => { return record.id }
}
- }
+ },
+ show: (record, store) => { return !['User'].includes(store.userInfo.roletype) },
+ groupShow: (record, store) => { return !['User'].includes(store.userInfo.roletype) }
Review comment:
Yup. Causes issues and shows stop / start based on the first vm's state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#issuecomment-664198914
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/539 (JID-2658)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #539: Consolidated Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#discussion_r460701512
##########
File path: src/config/section/event.js
##########
@@ -44,7 +44,9 @@ export default {
ids: {
value: (record) => { return record.id }
}
- }
+ },
+ show: (record, store) => { return !['User'].includes(store.userInfo.roletype) },
+ groupShow: (record, store) => { return !['User'].includes(store.userInfo.roletype) }
Review comment:
@davidjumani why not use the show as the implementation is same - the condition for showing the button can remain same? (or does it conflict with other views like stop/start vms etc.)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani closed pull request #539: More Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani closed pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org