You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/14 19:09:11 UTC
[GitHub] [incubator-seatunnel] humengyu2012 opened a new issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
humengyu2012 opened a new issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487
We have enabled code style checking: https://github.com/apache/incubator-seatunnel/blob/dev/tools/checkstyle/checkStyle.xml, but where is the xml profile? Manual compatibility code format is difficult.
<img width="698" alt="image" src="https://user-images.githubusercontent.com/45056332/158243389-805fd2d2-741d-4936-b52e-11d401382975.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067487845
In `/incubator-seatunnel/tools/checkstyle` folder, should install checkstyle plugin in idea. But have some problem with checkStyle.xml. Need somebody fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067556528
@humengyu2012 you didn't install the checkstyle plugin, this file https://github.com/apache/incubator-seatunnel/blob/dev/tools/checkstyle/checkStyle.xml is checkstyle configuration format but you import it as IntelliJ code style, it is definitely wrong, if you installed checkstyle plugin, you should have this menu item
<img width="411" alt="image" src="https://user-images.githubusercontent.com/15965696/158307464-b7b9938e-9373-48ec-924f-cf22283809dd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] humengyu2012 closed issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
humengyu2012 closed issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] humengyu2012 commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
humengyu2012 commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1070376859
I use checkstyle plugin instead of idea profile, it works. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067598216
> Since you don't have a clear context it's hard for me to tell, but #1490 is a known issue. @BenJFan But we need to be able to provide clear documentation at best
Developer guide need rewrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] tisonkun commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067571351
I second @kezhenxu94 's suggestion. One more point is that the default version of IDEA checkstyle plugin is 10.0 which is incompatible with seatunnel's setting.
@CalvinKirs I suggest seatunnel config checkstyle version explicitly in `pom.xml` so that it's fixed and easy to find for contributors.
But all in all, the default version of checkstyle of maven-checkstyle-plugin 3.1.0 is 8.19. And I've tested with 8.20.
It seems #1490 will upgrade to 3.1.2 and the default version of checkstyle becomes 8.29.
See also https://maven.apache.org/plugins/maven-checkstyle-plugin/history.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs edited a comment on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
CalvinKirs edited a comment on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067569587
Since you don't have a clear context it's hard for me to tell, but #1490 is a known issue. @BenJFan
But we need to be able to provide clear documentation at best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #1487: Where is IntelliJ IDEA code style XML or Eclipse XML Profile?
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #1487:
URL: https://github.com/apache/incubator-seatunnel/issues/1487#issuecomment-1067569587
Since you don't have a clear context it's hard for me to tell, but #1490 is a known issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org