[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1002: HDDS-1716. Smoketest results are generated with an internal user

[GitBox <gi...@apache.org>]

hadoop-yetus commented on a change in pull request #1002: HDDS-1716. Smoketest results are generated with an internal user
URL: https://github.com/apache/hadoop/pull/1002#discussion_r296221291
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/compose/testlib.sh
 ##########
 @@ -93,6 +97,12 @@ stop_docker_env(){
 
 ## @description  Generate robot framework reports based on the saved results.
 generate_report(){
-  #Generate the combined output and return with the right exit code (note: robot = execute test, rebot = generate output)
-  docker run --rm -v "$DIR/..:${OZONE_DIR:-/opt/hadoop}" apache/hadoop-runner rebot -d "$RESULT_DIR_INSIDE" "$RESULT_DIR_INSIDE/robot-*.xml"
+  which rebot > /dev/null 2>&1
+  if [ "$?" == "0" ]; then
 
 Review comment:
   shellcheck:8: note: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. [SC2181]
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org