[GitHub] [jena] afs commented on a diff in pull request #1378: Auth general bearer

[GitBox <gi...@apache.org>]

afs commented on code in PR #1378:
URL: https://github.com/apache/jena/pull/1378#discussion_r895381676


##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/auth/AuthBearerFilter.java:
##########
@@ -36,51 +37,66 @@
 
 /**
  * Process an "Authorization: Bearer" header.
- * If present, extract as JWT
  * <p>
  * This has two modes:
  * <ul>
- * <li>{@code requireBearer=true} : Only accept requests with a bearer
- * authorization header. If missing, respond with a 401 challenge asking for a
- * bearer token.</li>
+ * <li>{@code requireBearer=true} : Only accept requests with a bearer authorization
+ * header. If missing, respond with a 401 challenge asking for a bearer token.</li>
  * <li>{@code requireBearer=false} : Verify any bearer token but otherwise pass
  * through the request as-is. This will pass through requests to an unsecured
  * ("public") dataset but will cause a 403 on a secured dataset, not a 401
- * challenge.
+ * challenge.</li>
  * </ul>
  * <p>
- * A more flexible approach for mixing authentication methods is to setup Fuseki
- * with multiple {@code AuthBearerFilter} filters installed in a Fuseki
- * server, with different path specs.</li>
+ * Handling the bearer token is delegated to a handler function, passing the token as
+ * seen in the HTTP request. Normally, this will be base64 encoded. It is the
+ * responsibility of the handler function to decode the token.
+ * <p>
+ * This class has some extension points for customizing the handling of bearer
+ * authentication for
+ * <ul>
+ * <li>getting the token from the HTTP request (e.g. from a different HTTP field).</li>
+ * <li>handling the challenge case (no authentication provided)

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org