[GitHub] [superset] rumbin commented on pull request #14393: [WIP] feat: Set dataset name

[GitBox <gi...@apache.org>]

rumbin commented on pull request #14393:
URL: https://github.com/apache/superset/pull/14393#issuecomment-840141259


   > > There is no unique constraint on the SqlaTable table, so why do we need to introduce the dataset name?
   > 
   > ```
   >     __table_args__ = (UniqueConstraint("database_id", "table_name"),)
   > ```
   
   Wouldn't it be useful to have the schema included in this constraint? In most cases it is only the fully qualified db.schema.table name that really is unique by definition.
   The proposed approach of having a custom unique dataset name serves the same purpose, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org