[GitHub] [shardingsphere] sandynz commented on a diff in pull request #26429: CDC E2E add single table test.

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #26429:
URL: https://github.com/apache/shardingsphere/pull/26429#discussion_r1233589101


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/SingleTableInventoryDataConsistencyChecker.java:
##########
@@ -116,6 +116,14 @@ private DataConsistencyCheckResult check0(final Iterator<DataConsistencyCalculat
         long sourceRecordsCount = 0;
         long targetRecordsCount = 0;
         boolean contentMatched = true;
+        if (sourceCalculatedResults.hasNext() ^ targetCalculatedResults.hasNext()) {
+            if (sourceCalculatedResults.hasNext()) {
+                sourceRecordsCount = waitFuture(executor.submit(sourceCalculatedResults::next)).getRecordsCount();
+            } else {
+                targetRecordsCount = waitFuture(executor.submit(targetCalculatedResults::next)).getRecordsCount();
+            }
+            return new DataConsistencyCheckResult(new DataConsistencyCountCheckResult(sourceRecordsCount, targetRecordsCount), new DataConsistencyContentCheckResult(false));
+        }
         while (sourceCalculatedResults.hasNext() && targetCalculatedResults.hasNext()) {

Review Comment:
   Could we merge this block of code into while loop?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org