[GitHub] [beam] alexvanboxel commented on issue #11259: Use attachValues in SQL

[GitBox <gi...@apache.org>]

alexvanboxel commented on issue #11259: Use attachValues in SQL
URL: https://github.com/apache/beam/pull/11259#issuecomment-605790674
 
 
   > Use the more efficient attachValues when building rows in SQL. addValues does a deep copy of the parameter, while addValue does not. We have also recently made API improvements that makes addValues slightly less efficient, so this allows SQL to bypass that.
   > 
   > We are not using attachValues on any of the IOs. This is strictly for internal rows generated by SQL.
   
   I've changed from `while attachValues does not` too `while addValue does not`. (typo)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services