You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2017/01/10 13:37:32 UTC
[GitHub] couchdb-fabric pull request #83: Handle no_pass message when limit is 0
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-fabric/pull/83
Handle no_pass message when limit is 0
A view query that uses both a filter and a limit value can appear to
'hang' because the workers continue to run even after the number of
requested items have been returned, as workers that find no more
matches return 'no_pass' messages not 'change' messages, and thus the
short-circuiting code is never activated.
COUCHDB-3269
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-fabric 3269-filter-and-limit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fabric/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit f45be70172beb6b46b1e3a758527ea87787571c7
Author: Robert Newson <rn...@apache.org>
Date: 2017-01-09T12:30:02Z
Handle no_pass message when limit is 0
A view query that uses both a filter and a limit value can appear to
'hang' because the workers continue to run even after the number of
requested items have been returned, as workers that find no more
matches return 'no_pass' messages not 'change' messages, and thus the
short-circuiting code is never activated.
COUCHDB-3269
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
You decided to ignore the upgrade issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
We either need to make this two commits/PRs or figure out a way to feature flag it so that users running rolling reboots don't have a bunch of 500s during the upgrade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
+1 to the change but we should add a test for it. Granted there's not much in that module for tests right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric pull request #83: Handle no_pass message when limit is 0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
I don't agree that upgrading a cluster without downtime is something only Cloudant cares about. Granted we don't really have a process around this but I think we'll want to figure something out for these sorts of issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
sure, but let's agree that it's the right fix first? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
Rolling reboot upgrade requires multiple commits as well. But yeah, definitely something we should spend time figuring out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
+1 to the change but we should add a test for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
Fair. But even splitting into two commits would not be a signal to anyone. If we want to support smooth hot upgrade between releases we have a lot more work to do.
Sent from my iPhone
> On 12 Jan 2017, at 19:33, Paul J. Davis <no...@github.com> wrote:
>
> I don't agree that upgrading a cluster without downtime is something only Cloudant cares about. Granted we don't really have a process around this but I think we'll want to figure something out for these sorts of issues.
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fabric issue #83: Handle no_pass message when limit is 0
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-fabric/pull/83
No but this isn't the place to handle Cloudants upgrade problem. We'll split the commit elsewhere to make two tar balls.
Sent from my iPhone
> On 12 Jan 2017, at 14:09, Paul J. Davis <no...@github.com> wrote:
>
> You decided to ignore the upgrade issues?
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---