You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/02 05:52:21 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1571: HDDS-2228. Fix NPE in OzoneDelegationTokenManager#addPersistedDelegat…
bharatviswa504 commented on a change in pull request #1571: HDDS-2228. Fix NPE in OzoneDelegationTokenManager#addPersistedDelegat…
URL: https://github.com/apache/hadoop/pull/1571#discussion_r330380311
##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
##########
@@ -84,13 +84,16 @@
* milliseconds
* @param dtRemoverScanInterval how often the tokens are scanned for expired
* tokens in milliseconds
+ * @param certClient certificate client to SCM CA
*/
public OzoneDelegationTokenSecretManager(OzoneConfiguration conf,
long tokenMaxLifetime, long tokenRenewInterval,
long dtRemoverScanInterval, Text service,
- S3SecretManager s3SecretManager) throws IOException {
+ S3SecretManager s3SecretManager, CertificateClient certClient)
+ throws IOException {
super(new SecurityConfig(conf), tokenMaxLifetime, tokenRenewInterval,
service, LOG);
+ setCertClient(certClient);
Review comment:
I understood why it is done like this by adding a new method setCertClient, as the OzoneSecretManager is base class for OzoneBlockTokenSecretManager also. Does it look clean if we pass the certClient to superclass constructor?
If it is too much change I am fine with the current approach too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org