[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13778: Code cleanup & message improvements

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #13778:
URL: https://github.com/apache/druid/pull/13778#discussion_r1103890064


##########
core/src/main/java/org/apache/druid/data/input/impl/FlatTextInputFormat.java:
##########
@@ -143,4 +143,16 @@
   {
     return Objects.hash(listDelimiter, columns, findColumnsFromHeader, skipHeaderRows, delimiter);
   }
+
+  protected String fieldsToString()
+  {
+    return "FlatTextInputFormat{"
+        + "delimiter=\"" + delimiter
+        + "\"listDelimiter="
+        + listDelimiter == null ? "null" : "\"" + listDelimiter + "\""

Review Comment:
   ## Useless null check
   
   This check is useless, since [... + ...](1) always is non-null.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4264)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org