You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/06/16 14:15:29 UTC
[GitHub] zeppelin pull request #1028: [Zeppelin-1022] Apply new mechanism to LivyInte...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1028
[Zeppelin-1022] Apply new mechanism to LivyInterpreter
### What is this PR for?
Apply new mechanism to LivyInterpreter
### What type of PR is it?
[Improvement]
### Todos
* [x] - Apply new mechanism to LivyInterpreter
* [x] - rename zeppelin.livy.url to livy.host.url to make all params look livy.*
* [x] - surround interpreterContext.getAuthenticationInfo().getUser() with ""
### What is the Jira issue?
* [Zeppelin-1022](https://issues.apache.org/jira/browse/ZEPPELIN-1022)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1022
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1028
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1028: [Zeppelin-1022] Apply new mechanism to LivyInte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1028
@bzz I was referring to https://github.com/apache/zeppelin/pull/1034, ZEPPELIN-1009.
```
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.524 sec - in org.apache.zeppelin.integration.ZeppelinIT
Results :
Tests in error:
ParagraphActionsIT.testRemoveButton:153 » NoSuchElement Unable to locate eleme...
ParagraphActionsIT.testCreateNewButton:86 » NoSuchElement Unable to locate ele...
```
@jongyoul Thank you for testing it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1028
@prabhjyotsingh LGTM
> surround interpreterContext.getAuthenticationInfo().getUser() with ""
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1028
I've tested it. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1028
@prabhjyotsingh if we could point what is the reason of failure and link to either PR or existing JIRA issue that handles it - that could help improve our infrastructure a lot
Looks good to me
\cc @jongyoul as an author of new interpreter registration system for a reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1028
Will merge this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1028
CI fails for unrelated changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---