[jira] [Commented] (DAFFODIL-2780) Identity Transform SDE when using RepType int and baseType String

["Steve Lawrence (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DAFFODIL-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694589#comment-17694589 ] 

Steve Lawrence commented on DAFFODIL-2780:
------------------------------------------

I think I've found the issue, and fortunately it's just a simple typo. In some places in the schema, you have *dfdlx:repValue* instead of *dfdlx:repValues*, so singular when it should be plural.

I believe Daffodil wants to support schemas with unknown extensions, so if we see a dfdlx extension property we don't know (e.g. dfdlx:repValue) then we ignore it. And since Daffodil doesn't see any repValues on the enumerations, the types actually do need to be the same and the error message is correct.  So this is sort of behaving as expected.

I think the one thing that isn't behaving as expected is that we should be issuing warning when the *dfdlx:repValue* property is ignored. We do have logic to warning when properties are ignored, but likely however that is implemented does not apply to enumerations. I'll open a separate ticket for that.

[~olabusayo], can you confirm that fixing the the typos resolves the problem, and then we can resolve/close this?

> Identity Transform SDE when using RepType int and baseType String
> -----------------------------------------------------------------
>
>                 Key: DAFFODIL-2780
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2780
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End
>    Affects Versions: 3.4.0
>            Reporter: Olabusayo Kilo
>            Priority: Major
>             Fix For: 3.5.0
>
>
>  SchemaDefinitionError: Schema Definition Error: Identity transform requires that the basetype and reptype have a common primitive type
> Schema context: BasicSymbolCodesEnumTable Location line 2514 column 6 in file:/home/okilo@columbia.tresys.com/git/data-formats/usareur-otg/target/classes/com/owlcyberdefense/mtf-generator/xsd/otg-enums.dfdl.xsd
>  
> Schema project: [https://hqapp01.columbia.tresys.com/okilo_bug_examples/oth-gold-identitytransformbug/-/tree/identityTransformBug]
> Branch: identityTransform bug
> Replicated by: running "sbt test"
> daffodil git hash: 9540377c1b57c01b0e1b3dbf6d5534896c5c7567
> Attempts to replicate (thus far unsuccessful) in a smaller fashion can be found in src/test/resources/com/owlcyberdefense/otg2007/identityTransformError.tdml
> NOTE:  this reproduces the problem, but it's not a public resource.
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)