You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/10 16:43:28 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
donnerpeter opened a new pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347
…s, cleanup
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
We'd like Hunspell dictionaries not to take too much memory, especially when there's many of them loaded
# Solution
Print the memory usage of all known dictionaries together
# Tests
A test-only change
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574309396
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
}
} finally {
executor.shutdown();
- executor.awaitTermination(1, TimeUnit.MINUTES);
+ assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));
Review comment:
The test runner would also capture and report any escaped threads, even if this falls through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574316976
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
}
} finally {
executor.shutdown();
- executor.awaitTermination(1, TimeUnit.MINUTES);
+ assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));
Review comment:
Oh. I'm too addicted to IntelliJ and its warnings (especially having created some of them) :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574312611
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
}
} finally {
executor.shutdown();
- executor.awaitTermination(1, TimeUnit.MINUTES);
+ assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));
Review comment:
Use vim? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2347: LUCENE-9760: Hunspell: print total memory usage in TestAllDictionarie…
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2347:
URL: https://github.com/apache/lucene-solr/pull/2347#discussion_r574311027
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -181,11 +188,16 @@ public void testDictionariesLoadSuccessfully() throws Exception {
}
} finally {
executor.shutdown();
- executor.awaitTermination(1, TimeUnit.MINUTES);
+ assertTrue(executor.awaitTermination(1, TimeUnit.MINUTES));
Review comment:
This was yellow-highlighted by the IDE, and it was easier to surrender :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org