You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/03/13 08:12:14 UTC
[jira] [Commented] (TS-1671) It seems that AlarmListable in
overviewRecord is obsolete
[ https://issues.apache.org/jira/browse/TS-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600902#comment-13600902 ]
ASF subversion and git services commented on TS-1671:
-----------------------------------------------------
Commit ae21316cb1ace0afe69c4a3897151934da4618de in branch refs/heads/master from Zhao Yongming <mi...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ae21316 ]
TS-1671: remove AlarmListable from overviewRecord
> It seems that AlarmListable in overviewRecord is obsolete
> ---------------------------------------------------------
>
> Key: TS-1671
> URL: https://issues.apache.org/jira/browse/TS-1671
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Management
> Reporter: Yunkai Zhang
> Assignee: weijin
> Fix For: 3.3.2
>
> Attachments: 0001-TS-1671-Remove-useless-AlarmListable-and-related-fun.patch
>
>
> Yunkai Zhang <yu...@gmail.com>
> Jan 25 (5 days ago)
> to dev-trafficser.
> Hi folks:
> What is the purpose of AlarmListTable in overviewRecord? Does it outdate?
> It seems that, in the following steps:
> 1. Objects of AlarmListTable is added into overviewRecord::nodeAlarms and overviewRecord::notFoundAlarms lists by overviewAlarmCallback()/addAlarm()
> 2. And then, they are removed by checkAlarms()/addSelfRecord()
> AlarmListTable does nothing at all.
> If it's obsolete, I'm going to clean it.
> James Peach <jp...@apache.org>
> 1:47 PM (56 minutes ago)
> It looks like dead code to me. I'm going to guess it was once used for the Inktomi cache appliance? I would not be sorry to see all the web management removed ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira