[GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4742: Enable strict compile options on all scala projects and fix warnings.

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4742: Enable strict compile options on all scala projects and fix warnings.
URL: https://github.com/apache/openwhisk/pull/4742#discussion_r349020842
 
 

 ##########
 File path: tools/admin/src/main/scala/org/apache/openwhisk/core/database/LimitsCommand.scala
 ##########
 @@ -19,26 +19,18 @@ package org.apache.openwhisk.core.database
 
 import akka.actor.ActorSystem
 import akka.stream.ActorMaterializer
-import org.rogach.scallop.{ScallopConfBase, Subcommand}
-import spray.json.{JsObject, JsString, JsValue, RootJsonFormat}
 import org.apache.openwhisk.common.{Logging, TransactionId}
 import org.apache.openwhisk.core.cli.{CommandError, CommandMessages, IllegalState, WhiskCommand}
 import org.apache.openwhisk.core.database.LimitsCommand.LimitEntity
 import org.apache.openwhisk.core.entity.types.AuthStore
-import org.apache.openwhisk.core.entity.{
-  DocId,
-  DocInfo,
-  DocRevision,
-  EntityName,
-  Subject,
-  UserLimits,
-  WhiskAuth,
-  WhiskDocumentReader
-}
+import org.apache.openwhisk.core.entity._
 import org.apache.openwhisk.http.Messages
 import org.apache.openwhisk.spi.SpiLoader
+import org.rogach.scallop.{ScallopConfBase, Subcommand}
+import spray.json.{JsObject, JsString, JsValue, RootJsonFormat}
 
 import scala.concurrent.{ExecutionContext, Future}
+import scala.language.reflectiveCalls
 
 Review comment:
   This is the important change in both files. We're using structural types here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services