You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Seema Alevoor <Se...@Sun.COM> on 2008/06/18 12:38:36 UTC

Building pgsql DBD driver

Hi,

APR-UTIL's configure script sets 'LDADD_dbd_pgsql' to
       "$pgsql_LDFLAGS -lpq $pgsql_LIBS" (pgsql_LIBS = `pg_config --libs`)
whereas PostgresSQL README (src/port/README) says
    "For applications, we use -lpgport before -lpq, so the static files
    from libpgport are linked first."

In that case, shouldn't it be set to "$pgsql_LDFLAGS $pgsql_LIBS -lpq" ?


Thanks,
Seema.

Re: Building pgsql DBD driver

Posted by Bojan Smojver <bo...@rexursive.com>.
On Wed, 2008-06-18 at 11:52 +0100, Nick Kew wrote:

> Any reason we shouldn't just switch the ordering?

>>From memory, it won't build on Windows in that case. BTW, all this is
not required on Unix at all.

http://marc.info/?l=apr-dev&m=121132961724191&w=2

-- 
Bojan


Re: Building pgsql DBD driver

Posted by Nick Kew <ni...@apache.org>.
On Wed, 18 Jun 2008 16:08:36 +0530
Seema Alevoor <Se...@Sun.COM> wrote:

> Hi,
> 
> APR-UTIL's configure script sets 'LDADD_dbd_pgsql' to
>        "$pgsql_LDFLAGS -lpq $pgsql_LIBS" (pgsql_LIBS = `pg_config
> --libs`) 
> whereas PostgresSQL README (src/port/README) says
>     "For applications, we use -lpgport before -lpq, so the static
> files from libpgport are linked first."
> 
> In that case, shouldn't it be set to "$pgsql_LDFLAGS $pgsql_LIBS
> -lpq" ?

Makes sense to me.

The current ordering is introduced in r658532, and it seems that
other DBD drivers are potentially affected if they have any
ordering issues.

Any reason we shouldn't just switch the ordering?

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/