[jira] [Commented] (TC-416) traffic_router: tomcat shutdown problems

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083029#comment-16083029 ] 

ASF GitHub Bot commented on TC-416:
-----------------------------------

GitHub user guzzijason opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/724

    [TC-416] tomcat init script fixes for traffic_router

    Improving the reliabitiy of STOPPING tomcat service.
    
    1. Add following variables to init script:
    SHUTDOWN_TIMEOUT (default 10 seconds)
    SHUTDOWN_FORCE (default "true" - kill if the shutdown times out)
    
    2. Only export $CATALINA_OPTS when needed (to start the server)
    Tomcat control scripts do this fun thing where to stop the current
    jvm, catalina *starts* a second jvm, which then tells the first
    to stop. This is all well and good, except we really don't want
    to start this second jvm with our custom $CATALINA_OPTS, especially
    on servers under memory pressure!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guzzijason/incubator-trafficcontrol tomcat-init

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #724
    
----
commit 77d92d9ff0b60f0d372186f7c607de806e73ca19
Author: Jason Tucker <ja...@comcast.com>
Date:   2017-07-11T20:59:32Z

    tomcat init script fixes for traffic_router
    
    Improving the reliabitiy of STOPPING tomcat service.
    
    1. Add following variables to init script:
    SHUTDOWN_TIMEOUT (default 10 seconds)
    SHUTDOWN_FORCE (default "true" - kill if the shutdown times out)
    
    2. Only export $CATALINA_OPTS when needed (to start the server)
    Tomcat control scripts do this fun thing where to stop the current
    jvm, catalina *starts* a second jvm, which then tells the first
    to stop. This is all well and good, except we really don't want
    to start this second jvm with our custom $CATALINA_OPTS, especially
    on servers under memory pressure!

----


> traffic_router: tomcat shutdown problems
> ----------------------------------------
>
>                 Key: TC-416
>                 URL: https://issues.apache.org/jira/browse/TC-416
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Router
>            Reporter: Jason Tucker
>              Labels: tomcat
>
> The tomcat init script has a few problems:
> 1. "Clean" shutdowns frequently timeout, and the scripts give up, leaving tomcat running
> 2. Normal tomcat shutdown actually involves spinning up a second jvm instance. Right now, we start this second instance with the same CATALINA_OPTS as traffic_router, which can be problematic on memory-constrained hosts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)