You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/03/14 08:48:34 UTC
[GitHub] [jena] kinow opened a new pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
kinow opened a new pull request #1226:
URL: https://github.com/apache/jena/pull/1226
…ry the backend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1226:
URL: https://github.com/apache/jena/pull/1226#discussion_r837336896
##########
File path: jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue
##########
@@ -24,16 +24,20 @@
<b-card-header header-tag="nav">
<Menu :dataset-name="datasetName" />
</b-card-header>
- <b-card-body>
+ <b-card-body v-if="!this.services['gsp-rw'] || this.services['gsp-rw'].length === 0">
+ <b-alert show variant="warning">No service for Graph Store Protocol configured</b-alert>
Review comment:
Uses may not associate GSP with thier task of adding data. Maybe working like:
```suggestion
<b-alert show variant="warning">No service for adding data available. The Graph Store Protocol service should be configured to allow adding data.</b-alert>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow edited a comment on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066625003
Sort of fixed. Pending:
- [ ] test other views and components
- [x] test both cases, where we have multiple services configured for the dataset, and also a dataset with just the query service as in the geosparql example
- [ ] confirm that the `gsp-rw` is necessary to upload data
- [ ] confirm what is necessary for the edit graph
- [x] check if unit tests are working after this change
Now :sleeping_bed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #1226:
URL: https://github.com/apache/jena/pull/1226#discussion_r825709050
##########
File path: jena-fuseki2/jena-fuseki-webapp/pom.xml
##########
@@ -57,6 +57,12 @@
<version>4.5.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.jena</groupId>
+ <artifactId>jena-geosparql</artifactId>
+ <version>4.5.0-SNAPSHOT</version>
+ </dependency>
Review comment:
Ops, I will remove this change. Only added it to test the GeoSparql pull request :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow edited a comment on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066625003
Sort of fixed. Pending:
- [ ] test other views and components
- [ ] test both cases, where we have multiple services configured for the dataset, and also a dataset with just the query service as in the geosparql example
- [ ] confirm that the `gsp-rw` is necessary to upload data
- [ ] confirm what is necessary for the edit graph
- [x] check if unit tests are working after this change
Now :sleeping_bed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066623357
I think the `/` endpoint, used as a service for `query` cannot handle uploads? I'm extracting the upload URL from the `gsp-rw` service. Does that sound correct?
And will display a message to the user about the missing service. What others think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066625003
Sort of fixed. Pending:
- [ ] test other views and components
- [ ] test both cases, where we have multiple services configured for the dataset, and also a dataset with just the query service as in the geosparql example
- [ ] confirm that the `gsp-rw` is necessary to upload data
- [ ] confirm what is necessary for the edit graph
- [ ] check if unit tests are working after this change
Now :sleeping_bed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow edited a comment on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066625003
Sort of fixed. Pending:
- [x] test other views and components
- [x] test both cases, where we have multiple services configured for the dataset, and also a dataset with just the query service as in the geosparql example
- [ ] confirm that the `gsp-rw` is necessary to upload data
- [ ] confirm what is necessary for the edit graph
- [x] check if unit tests are working after this change
Now :sleeping_bed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1081314423
Using the GeoSPARQL docs dataset, and a normal TDB2 dataset to test. This PR changes `Upload` and `Edit` only. Here's a preview of these views for the two aforementioned datasets.
The views do not display the forms when there are no `gsp-rw` graphs configured. @afs all done now, if that's looking OK it should be ready to be merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #1226:
URL: https://github.com/apache/jena/pull/1226#discussion_r837338670
##########
File path: jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue
##########
@@ -24,16 +24,20 @@
<b-card-header header-tag="nav">
<Menu :dataset-name="datasetName" />
</b-card-header>
- <b-card-body>
+ <b-card-body v-if="!this.services['gsp-rw'] || this.services['gsp-rw'].length === 0">
+ <b-alert show variant="warning">No service for Graph Store Protocol configured</b-alert>
Review comment:
Will copy the text in Upload.vue too. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1074668875
Still not able to edit the data for the GeoSPARQL dataset.
I guess we also need the `gsp-rw` service enabled for that? If so I will disable the UI when the selected dataset is missing that option.
The rest of the UI is looking OK, so I think the change here will fix the issue of the service endpoint. Ready for an initial review, pending some questions/checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs edited a comment on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
afs edited a comment on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1074897421
> confirm that the gsp-rw is necessary to upload data
Yes.
The "gsp-rw" includes the extension for loading quads.
There is another server "upload", which is no longer added in the default setup. "gsp-rw" calls the "upload" functionality when it receives a file without the GSP `?default` and `?graph=` parameters so it is a superset.
The GeoSPARQL example is read-only.
> Similar to the previous question, is there a service that must be enabled so that the UI can edit the graph in the UI?
"gsp-rw" - the edit facility is "fetch graph, edit locally, put back graph".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1073643723
@afs , are you able to answer these two?
>confirm that the gsp-rw is necessary to upload data
The GeoSPARQL example from the documentation doesn't seem to allow uploading data? Or is it a bug in the UI?
```ttl
<#service> rdf:type fuseki:Service;
fuseki:name "geo";
fuseki:endpoint [ fuseki:operation fuseki:query; ] ;
fuseki:dataset <#geo_ds> .
<#geo_ds> rdf:type geosparql:geosparqlDataset ;
geosparql:spatialIndexFile "DB/spatial.index";
geosparql:dataset <#baseDataset> ;
.
<#baseDataset> rdf:type tdb2:DatasetTDB2 ;
tdb2:location "DB/" ;
.
```
>confirm what is necessary for the edit graph
Similar to the previous question, is there a service that must be enabled so that the UI can edit the graph in the UI?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1075320190
> I think the / endpoint, used as a service for query cannot handle uploads?
Yes, it can. The "/" endpoint, by default" can handle an SPARQL operation. With MIME type and query parameter inspection, there is just enough information to disambiguate request types.
But probably better to use the named endpoint.
A single-use endpoint assumes the operation is correct for type, checks it, and executes it, or returns 4xx. They are slightly more forgiving sometimes. Not much in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow edited a comment on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1066625003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1074990068
Perfect, I'll update the Edit view to tell the user when it's not usable due to the missing service. Thanks @afs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #1226:
URL: https://github.com/apache/jena/pull/1226#discussion_r836985997
##########
File path: jena-fuseki2/jena-fuseki-webapp/pom.xml
##########
@@ -57,6 +57,12 @@
<version>4.5.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.jena</groupId>
+ <artifactId>jena-geosparql</artifactId>
+ <version>4.5.0-SNAPSHOT</version>
+ </dependency>
Review comment:
Reverted the change :+1: But thanks for offering to handle this @afs :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1226:
URL: https://github.com/apache/jena/pull/1226#issuecomment-1074897421
> confirm that the gsp-rw is necessary to upload data
Yes.
The "gsp-rw" includes the extension for loading quads.
There is another server "upload", which is no longer added in the default setup. "gsp-rw" calls the "upload" functionality when it receives a file without the GSP `?default` and `?graph=` parameters so it is a superset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1226:
URL: https://github.com/apache/jena/pull/1226#discussion_r835449183
##########
File path: jena-fuseki2/jena-fuseki-webapp/pom.xml
##########
@@ -57,6 +57,12 @@
<version>4.5.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.jena</groupId>
+ <artifactId>jena-geosparql</artifactId>
+ <version>4.5.0-SNAPSHOT</version>
+ </dependency>
Review comment:
Shall I merge then remove this? I'm clearing up prior to 4.5 so in the area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow merged pull request #1226: [JENA-2312] Use the service endpoint in the URL used by the UI to que…
Posted by GitBox <gi...@apache.org>.
kinow merged pull request #1226:
URL: https://github.com/apache/jena/pull/1226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org