You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Alfred Nathaniel <an...@apache.org> on 2008/05/30 23:45:26 UTC

Re: svn commit: r661886 - in /cocoon/trunk: ./ project/

On Fri, 2008-05-30 at 21:40 +0000, anathaniel@apache.org wrote:
> Author: anathaniel
> Date: Fri May 30 14:40:23 2008
> New Revision: 661886
> 
> URL: http://svn.apache.org/viewvc?rev=661886&view=rev
> Log:
> Move all files from /trunk to /trunk/project.
> Otherwise these files would never show up in Eclipse.
> 
> Added:
>     cocoon/trunk/1ST_README.txt
>     cocoon/trunk/project/
>     cocoon/trunk/project/.project
>     cocoon/trunk/project/README.txt
>       - copied, changed from r661475, cocoon/trunk/README.txt
>     cocoon/trunk/project/build-docs.sh
>       - copied, changed from r661475, cocoon/trunk/build-docs.sh
>     cocoon/trunk/project/build.sh
>       - copied unchanged from r661475, cocoon/trunk/build.sh
>     cocoon/trunk/project/cocoon.sh
>       - copied, changed from r661475, cocoon/trunk/cocoon.sh
>     cocoon/trunk/project/pom.xml
>       - copied, changed from r661475, cocoon/trunk/pom.xml
>     cocoon/trunk/project/settings.xml
>       - copied unchanged from r661475, cocoon/trunk/settings.xml
> Removed:
>     cocoon/trunk/README.txt
>     cocoon/trunk/build-docs.sh
>     cocoon/trunk/build.sh
>     cocoon/trunk/cocoon.sh
>     cocoon/trunk/pom.xml
>     cocoon/trunk/settings.xml

I suppose this change will break the continuum build.
Could somebody with enough karma please change the build to start off
in /trunk/project.

Cheers, Alfred.



Re: svn commit: r661886 - in /cocoon/trunk: ./ project/

Posted by Grzegorz Kossakowski <gr...@tuffmail.com>.
Alfred Nathaniel pisze:
> I found it very annoying that part of the files, especially the root and
> parent pom.xml, where not visible in Eclipse.  (Do other IDEs do it
> better?)

Don't know about other IDEs but AFAIR even Eclipse can perform better in this area when special 
Maven plug-in for Eclipse is used. It's called q4e[1] but the last time I checked it had one 
annoying problem: performed really slow when such big projects like Cocoon were handled by that 
plug-in. Don't know how it's now.

Speaking about myself, I don't change these files too often and always has been using external tools 
(Krusader on openSUSE) to deal with these files.

>> I think you should at least inform others that you are going to do such changes so others could have 
>> a chance to comment on idea. They are really far from being cosmetic.
> 
> Sure, the implications may be more drastic than imagined first.  If it
> is a problem, the changes are easy to revert.

I think the best option is to revert these changes and discuss possible options first. I guess that 
folks working with trunk may have their build broken as well.

>> By the way, is there any reason for telling people to use *.sh scripts instead of Maven directly?
> 
> I find that easier to explain than all the MAVEN_OPTS magic required
> when using mvn directly.

Hmmmm... I thought that recent releases of Maven does not need messing with MAVEN_OPTS. Am I wrong?

[1] http://code.google.com/p/q4e/

-- 
Grzegorz Kossakowski

Re: svn commit: r661886 - in /cocoon/trunk: ./ project/

Posted by Alfred Nathaniel <an...@apache.org>.
On Fri, 2008-05-30 at 23:52 +0200, Grzegorz Kossakowski wrote:

> Are you sure that having these files listed in Eclipse is enough reason to move them? Personally 
> speaking, I'm not so keen on this idea even if using Eclipse.

I found it very annoying that part of the files, especially the root and
parent pom.xml, where not visible in Eclipse.  (Do other IDEs do it
better?)

> I think you should at least inform others that you are going to do such changes so others could have 
> a chance to comment on idea. They are really far from being cosmetic.

Sure, the implications may be more drastic than imagined first.  If it
is a problem, the changes are easy to revert.

> By the way, is there any reason for telling people to use *.sh scripts instead of Maven directly?

I find that easier to explain than all the MAVEN_OPTS magic required
when using mvn directly.

Cheers, Alfred.



Re: svn commit: r661886 - in /cocoon/trunk: ./ project/

Posted by Grzegorz Kossakowski <gr...@tuffmail.com>.
Alfred Nathaniel pisze:
> On Fri, 2008-05-30 at 21:40 +0000, anathaniel@apache.org wrote:
>> Author: anathaniel
>> Date: Fri May 30 14:40:23 2008
>> New Revision: 661886
>>
>> URL: http://svn.apache.org/viewvc?rev=661886&view=rev
>> Log:
>> Move all files from /trunk to /trunk/project.
>> Otherwise these files would never show up in Eclipse.
>>
>> Added:
>>     cocoon/trunk/1ST_README.txt
>>     cocoon/trunk/project/
>>     cocoon/trunk/project/.project
>>     cocoon/trunk/project/README.txt
>>       - copied, changed from r661475, cocoon/trunk/README.txt
>>     cocoon/trunk/project/build-docs.sh
>>       - copied, changed from r661475, cocoon/trunk/build-docs.sh
>>     cocoon/trunk/project/build.sh
>>       - copied unchanged from r661475, cocoon/trunk/build.sh
>>     cocoon/trunk/project/cocoon.sh
>>       - copied, changed from r661475, cocoon/trunk/cocoon.sh
>>     cocoon/trunk/project/pom.xml
>>       - copied, changed from r661475, cocoon/trunk/pom.xml
>>     cocoon/trunk/project/settings.xml
>>       - copied unchanged from r661475, cocoon/trunk/settings.xml
>> Removed:
>>     cocoon/trunk/README.txt
>>     cocoon/trunk/build-docs.sh
>>     cocoon/trunk/build.sh
>>     cocoon/trunk/cocoon.sh
>>     cocoon/trunk/pom.xml
>>     cocoon/trunk/settings.xml
> 
> I suppose this change will break the continuum build.
> Could somebody with enough karma please change the build to start off
> in /trunk/project.

Hi Alfred,

Are you sure that having these files listed in Eclipse is enough reason to move them? Personally 
speaking, I'm not so keen on this idea even if using Eclipse.

I think you should at least inform others that you are going to do such changes so others could have 
a chance to comment on idea. They are really far from being cosmetic.

By the way, is there any reason for telling people to use *.sh scripts instead of Maven directly?

-- 
Best regards,
Grzegorz Kossakowski