You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Peter (JIRA)" <ji...@apache.org> on 2013/08/15 06:32:48 UTC

[jira] [Created] (CB-4588) Documentation for noticiation.confirm should say to pass buttonLabels as Array

Peter created CB-4588:
-------------------------

             Summary: Documentation for noticiation.confirm should say to pass buttonLabels as Array
                 Key: CB-4588
                 URL: https://issues.apache.org/jira/browse/CB-4588
             Project: Apache Cordova
          Issue Type: Improvement
          Components: Docs
    Affects Versions: 2.9.0
            Reporter: Peter
            Assignee: Michael Brooks
            Priority: Minor


Compare navigator.notification.confirm and navigator.notification.prompt.

Both APIs allow caller to specifiy *buttonLabels* as 4th parameter, but confirm expects a comma separated String and prompt expects an array. The parameter passing mechanism should be consistent for these similar APIs.

It looks like the cordova.js is already handling the scenario, because it says:
{code}
console.log("Notification.confirm(string, function, string, string) is deprecated.  Use Notification.confirm(string, function, string, array).");
{code}

But the documentation for navigator.confirm is out-of-step with the code; it should be updated to say to pass Array, not String.

Seems related to CB-1933

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira