[GitHub] [airflow] mcw0933 opened a new pull request #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1

[GitBox <gi...@apache.org>]

mcw0933 opened a new pull request #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1
URL: https://github.com/apache/airflow/pull/5297
 
 
       https://issues.apache.org/jira/browse/AIRFLOW-2143
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
     * Root cause of this bug is that the `TaskInstance.try_number` property returns a value 1 higher than the completed tries, which is useful for logging.  The TaskTries graph was binding to this property, making it seem as though untried tasks had "1" try, and single-try tasks had "2'.
     * Adds a new read-only property to the `TaskInstance` model to provide count of previous task tries
     * Modify the `tries` view to bind the graph y-axis values to this property instead of `try_number`
   
   ### Tests
   
   - [x ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
     * No tests - property instance is read-only and is only used by graph view.  No existing tests for the `next_try_number` read-only property of this model, so I assume this is ok.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services