You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2016/04/06 22:17:38 UTC
Review Request 45833: Webhcat Server failed to stop while stopping
all the services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Bugs: AMBARI-15744
https://issues.apache.org/jira/browse/AMBARI-15744
Repository: ambari
Description
-------
Ambari uses {code}/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop{code} to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
In case {code}/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop{code} raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
Diff: https://reviews.apache.org/r/45833/diff/
Testing
-------
Manual testing.
Ambari server python unit tests:
----------------------------------------------------------------------
Total run:944
Total errors:0
Total failures:0
Thanks,
Sebastian Toader
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/#review127445
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 6, 2016, 8:21 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45833/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 8:21 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-15744
> https://issues.apache.org/jira/browse/AMBARI-15744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
>
> In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
>
> Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
>
> Diff: https://reviews.apache.org/r/45833/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Ambari server python unit tests:
> ----------------------------------------------------------------------
> Total run:944
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/#review127584
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py (line 61)
<https://reviews.apache.org/r/45833/#comment190985>
I guess we should not just skip any exceptions happened. We probably want to do that only for Fail type, not import/semantic errors.
Also some logging is required on what exception failed here, silently swalowing is a bad practice.
ignore_failures = True, does that job, you may try using it.
- Andrew Onischuk
On April 6, 2016, 8:21 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45833/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 8:21 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-15744
> https://issues.apache.org/jira/browse/AMBARI-15744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
>
> In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
>
> Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
>
> Diff: https://reviews.apache.org/r/45833/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Ambari server python unit tests:
> ----------------------------------------------------------------------
> Total run:944
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/#review127586
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On April 7, 2016, 12:55 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45833/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 12:55 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-15744
> https://issues.apache.org/jira/browse/AMBARI-15744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
>
> In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
>
> Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 487f078
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 86f185d
>
> Diff: https://reviews.apache.org/r/45833/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Ambari server python unit tests:
> ----------------------------------------------------------------------
> Total run:944
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/
-----------------------------------------------------------
(Updated April 7, 2016, 2:55 p.m.)
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Bugs: AMBARI-15744
https://issues.apache.org/jira/browse/AMBARI-15744
Repository: ambari
Description
-------
Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 487f078
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 86f185d
Diff: https://reviews.apache.org/r/45833/diff/
Testing
-------
Manual testing.
Ambari server python unit tests:
----------------------------------------------------------------------
Total run:944
Total errors:0
Total failures:0
Thanks,
Sebastian Toader
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/
-----------------------------------------------------------
(Updated April 7, 2016, 2:54 p.m.)
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Changes
-------
Catch only Fail exceptions to in order to not swallow other type of errors like semantic etc errors.
Bugs: AMBARI-15744
https://issues.apache.org/jira/browse/AMBARI-15744
Repository: ambari
Description
-------
Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
Diff: https://reviews.apache.org/r/45833/diff/
Testing
-------
Manual testing.
Ambari server python unit tests:
----------------------------------------------------------------------
Total run:944
Total errors:0
Total failures:0
Thanks,
Sebastian Toader
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/#review127570
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Апрель 6, 2016, 8:21 п.п., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45833/
> -----------------------------------------------------------
>
> (Updated Апрель 6, 2016, 8:21 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-15744
> https://issues.apache.org/jira/browse/AMBARI-15744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
>
> In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
>
> Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
>
> Diff: https://reviews.apache.org/r/45833/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
> Ambari server python unit tests:
> ----------------------------------------------------------------------
> Total run:944
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 45833: Webhcat Server failed to stop while
stopping all the services
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45833/
-----------------------------------------------------------
(Updated April 6, 2016, 10:21 p.m.)
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Bugs: AMBARI-15744
https://issues.apache.org/jira/browse/AMBARI-15744
Repository: ambari
Description (updated)
-------
Ambari uses `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` to stop WebHCat server. Since this command may return fine without being able to shut down WebHCat server Ambari performs another round of check to see if the WebHCat process is still alive and kill it .
In case `/usr/hdp/current/hive-webhcat/sbin/webhcat_server.sh stop` raised an exception the stopping sequence exited early before the logic that would force-kill WebHCat got executed.
Modified the stop procedure such as always verifies at the end if the process is still alive and kills it.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 6fe49dc
Diff: https://reviews.apache.org/r/45833/diff/
Testing
-------
Manual testing.
Ambari server python unit tests:
----------------------------------------------------------------------
Total run:944
Total errors:0
Total failures:0
Thanks,
Sebastian Toader