You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "hk-lrzy (via GitHub)" <gi...@apache.org> on 2024/05/23 08:22:08 UTC

Re: [PR] [MSHADE-452]Fix ServiceResourceTransformer not correct issue. [maven-shade-plugin]

hk-lrzy commented on PR #193:
URL: https://github.com/apache/maven-shade-plugin/pull/193#issuecomment-2126515899

   > Hi @hk-lrzy , sorry for the delay (guess the PR popped during holidays). From my window this PR has the risk to revert some of the fixes done before. Long story short shade mixing the same API (relocation) for sources (variables, classes, packages), paths and other things, there is always a such a risk so ultimately I think a safer fix would make the relocated file more contextual (`if (filePath ~ META-INF/services/xxxxxx` then use relocateSPIFile()` to share the idea).
   > 
   > Hope it makes sense.
   
   Thanks for reply, i will recheck the logical follow your suggestion and commit it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org