You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Lynn Gallinat <lg...@pivotal.io> on 2017/08/23 16:55:28 UTC
Review Request 61852: GEODE-3507 actualRedundantCopies stat in
org.apache.geode.internal.cache.PartitionedRegionStats can go negative
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and Nick Reich.
Repository: geode
Description
-------
The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's work, but will now not allow -1 to be written to stats
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java 38ef61b
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java 0917835
Diff: https://reviews.apache.org/r/61852/diff/1/
Testing
-------
Precheckin (all green)
I repeatedly ran one of the tests that reproduced this problem and it passed 370 times.
I ran selected partitioned region bts (totaling 536 PR tests) and the only failures were auto-diagnosed.
Thanks,
Lynn Gallinat
Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in
org.apache.geode.internal.cache.PartitionedRegionStats can go negative
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/#review183626
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 23, 2017, 9:55 a.m., Lynn Gallinat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61852/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 9:55 a.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and Nick Reich.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's work, but will now not allow -1 to be written to stats
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java 38ef61b
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java 0917835
>
>
> Diff: https://reviews.apache.org/r/61852/diff/1/
>
>
> Testing
> -------
>
> Precheckin (all green)
> I repeatedly ran one of the tests that reproduced this problem and it passed 370 times.
> I ran selected partitioned region bts (totaling 536 PR tests) and the only failures were auto-diagnosed.
>
>
> Thanks,
>
> Lynn Gallinat
>
>
Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in
org.apache.geode.internal.cache.PartitionedRegionStats can go negative
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/#review183627
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Aug. 23, 2017, 4:55 p.m., Lynn Gallinat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61852/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 4:55 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and Nick Reich.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's work, but will now not allow -1 to be written to stats
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java 38ef61b
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java 0917835
>
>
> Diff: https://reviews.apache.org/r/61852/diff/1/
>
>
> Testing
> -------
>
> Precheckin (all green)
> I repeatedly ran one of the tests that reproduced this problem and it passed 370 times.
> I ran selected partitioned region bts (totaling 536 PR tests) and the only failures were auto-diagnosed.
>
>
> Thanks,
>
> Lynn Gallinat
>
>