You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/13 20:13:52 UTC
[GitHub] [solr] epugh opened a new pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
epugh opened a new pull request #745:
URL: https://github.com/apache/solr/pull/745
https://issues.apache.org/jira/browse/SOLR-16096
# Description
The `createNodeSet` parameter is hidden from the admin gui, and we need it for a project ;-).
# Solution
I dithered about adding the magic `EMPTY` value or the related `createNodeSet.shuffle` parameter, but didn't need it for my specific itch. I introduced the selectize.js library as it supports multiple select... A thought for the future would be to remove the use of the chosen.js library?
One thing I don't love is that I duplicated the lookup of the available `nodeSets` but couldn't quite figure out how to extract it as a proper function, would love a suggestion ;-)
I'd like to back port this to the 8.11 line....
# Tests
Manual testing.
# Checklist
Please review the following and check all that apply:
- [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ X] I have created a Jira issue and added the issue ID to my pull request title.
- [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ X] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #745:
URL: https://github.com/apache/solr/pull/745#discussion_r830515067
##########
File path: solr/webapp/web/libs/angular-selectize.js
##########
@@ -0,0 +1,107 @@
+/**
+ * Angular Selectize2
+ * https://github.com/machineboy2045/angular-selectize
Review comment:
Should reference the license in this file? https://github.com/machineboy2045/angular-selectize/blob/master/LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1066175533
Also, I'd love help on how to exclude the css file from being validated?
```
> Task :solr:webapp:validateSourcePatterns FAILED
@author javadoc tag: /Users/epugh/Documents/projects/solr-epugh-2/solr/webapp/web/css/angular/selectize.css
javadoc-style license header [Apache License Version 2.0]: /Users/epugh/Documents/projects/solr-epugh-2/solr/webapp/web/css/angular/selectize.css
Execution failed for task ':solr:webapp:validateSourcePatterns'.
> Found 2 violations in source files (@author javadoc tag, javadoc-style license header [Apache License Version 2.0]).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1073827388
Thanks @risdenk for the pointer!
One thing that I realized as I looked at #594 is that it also introduces a better multiselect tool... I don't know which of the http://github.com/angular-ui/ui-select that it uses versus the https://github.com/machineboy2045/angular-selectize that this PR uses is better, but it may make sense to pick one ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1066175351
I noticed the the file `/solr/webapp/build.gradle` excludes some Angular files, however I didn't follow the pattern and add the `selectize.js` or `angular-selectize.js` files to the list...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1076570987
Good point... The one thing I haven't been able to test out with angular-selectize is the ability to resort your list of choices using your mouse, this would be use ful for when the order of your selections matters (looking at you, `useParams`), but I haven't been able to get that aspect of the selectize library to work yet.
Honestly, everything we use, since we are Angular1, is either archived/deprecated/ or otherwise not really maintained ;-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1076568542
https://github.com/angular-ui/ui-select is archived. So https://github.com/machineboy2045/angular-selectize seems like a better option? angular-selectize has some comparisons to ui-select as well so seems like it came after ui-select?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org