You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Carsten Ziegeler <cz...@apache.org> on 2008/04/29 16:47:08 UTC

Moving default-rtp to samples?

Hi,

I think we should move the default-rtp bundle from the jcr dir to the 
samples. It's a nice little module which more servers as a sample.

Carsten
-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Moving default-rtp to samples?

Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Apr 29, 2008 at 5:11 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> 
>> ...I think we should move the integration tests to a separate module
>> as ewll....
> 
> As long as they run automatically and can also be run against a
> separate Sling instance, I'm fine.
> 
> We'll have to find a way for bundles to contribute additional tests at
> some point - currently, for example, there's no way to add a new
> scripting engine bundle and have that cause additional integration
> tests to run.
> 
Yepp - that's why I would move the integration tests into a separate 
module that installs all available bundles and contains all integration 
tests.
Or a bundle might create two bundles, the usual bundle and one 
containing just the integration tests.

Carsten

-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Moving default-rtp to samples?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Apr 29, 2008 at 5:11 PM, Carsten Ziegeler <cz...@apache.org> wrote:

> ...I think we should move the integration tests to a separate module
> as ewll....

As long as they run automatically and can also be run against a
separate Sling instance, I'm fine.

We'll have to find a way for bundles to contribute additional tests at
some point - currently, for example, there's no way to add a new
scripting engine bundle and have that cause additional integration
tests to run.

-Bertrand

Re: Moving default-rtp to samples?

Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Apr 29, 2008 at 4:55 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> 
>> ... For what is it used there?...
> 
> Integration tests only at the moment, which verify that the mechanism works.
> 
:) Ok - I think we should move the integration tests to a separate 
module as ewll.

> But I suspect we'll use it for examples as well, once we finally create them ;-)
hehe, yes, "once"

I'm currently thinking about "cleaning up" our repository which means 
moving stuff to their "correct" location.

Carsten

-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Moving default-rtp to samples?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Apr 29, 2008 at 4:55 PM, Carsten Ziegeler <cz...@apache.org> wrote:

> ... For what is it used there?...

Integration tests only at the moment, which verify that the mechanism works.

But I suspect we'll use it for examples as well, once we finally create them ;-)

-Bertrand

Re: Moving default-rtp to samples?

Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Tue, Apr 29, 2008 at 4:47 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ... I think we should move the default-rtp bundle from the jcr dir to the
>> samples. It's a nice little module which more servers as a sample....
> 
> Agreed, but note that it is used by launchpad/app (which is itself
> also kind of a sample, so that's fine I guess)
> 
For what is it used there?

Carsten

-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Moving default-rtp to samples?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Apr 29, 2008 at 4:47 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ... I think we should move the default-rtp bundle from the jcr dir to the
> samples. It's a nice little module which more servers as a sample....

Agreed, but note that it is used by launchpad/app (which is itself
also kind of a sample, so that's fine I guess)

-Bertrand