[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7281: Docker go tests runners: Unwrap commands from bash shell to inherit environment variables

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #7281:
URL: https://github.com/apache/trafficcontrol/pull/7281#discussion_r1067170884


##########
traffic_ops/app/bin/tests/Dockerfile-golangtest:
##########
@@ -20,6 +20,7 @@ ARG DIR=github.com/apache/trafficcontrol
 COPY --from=get-go /usr/local/go /usr/local/go
 ENV PATH=/usr/local/go/bin:${PATH} \
     GOPATH=/go
+ENV	PATH=${GOPATH}/bin:${PATH}

Review Comment:
   same as above



##########
traffic_monitor/tests/Dockerfile-golangtest:
##########
@@ -18,6 +18,7 @@ FROM debian:buster
 COPY --from=get-go /usr/local/go /usr/local/go
 ENV PATH=/usr/local/go/bin:${PATH} \
     GOPATH=/go
+ENV	PATH=${GOPATH}/bin:${PATH}

Review Comment:
   `PATH` is offset from `ENV` by a tab character, I think it should be a space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org