You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Denis Cabasson (JIRA)" <ji...@codehaus.org> on 2007/07/23 15:19:13 UTC
[jira] Commented: (MECLIPSE-304) Removing @execute
phase="generate-resources"
[ http://jira.codehaus.org/browse/MECLIPSE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102952 ]
Denis Cabasson commented on MECLIPSE-304:
-----------------------------------------
the @execute tag shouldn't be removed. It is here to ensure the generate-resources phase is executed prior to the call to eclipse:eclipse mojo.
Why would you want to have it removed?
For projects with source code generation (projects using modello or castor), this ensure aditionnal java sources have been generated and attached as source resources to the project before generation of the eclipse descriptor.
Changing @execute by @phase would only bind the eclipse:eclipse mojo to the phase, without ensuring it has been executed.
> Removing @execute phase="generate-resources"
> --------------------------------------------
>
> Key: MECLIPSE-304
> URL: http://jira.codehaus.org/browse/MECLIPSE-304
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Affects Versions: 2.4
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Priority: Minor
>
> eclipse:m2eclipse and eclipse:eclipse shouldn't have to @execute phase="generate-resources".
> By removing this line and adding @phase generate-resources I can now run eclipse:eclipse at the parent POM level as well as at the module level, with ONE CATCH:
> In org.apache.maven.plugin.eclipse.EclipsePlugin theres a TODO:
> // TODO: Why are we using project in some places, and executedProject in others??
> Well, once you remove the @execute you receive a barrage of NPE's.
> However if within org.apache.maven.plugin.eclipse.EclipsePlugin @ validate() I add
> executedProject = this.project; to the top, everything works like a charm.
> Can a configuration or flag be added that allows no @execution with the above modification?
> Regards,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira