You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2023/07/20 03:10:12 UTC
[GitHub] [doris] zddr opened a new pull request, #22019: [improvement](auth)select priv for new planner
zddr opened a new pull request, #22019:
URL: https://github.com/apache/doris/pull/22019
## Proposed changes
Issue Number: close #xxx
New optimizer select permission supports catalog
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #22019: [improvement](auth)select priv for Nereids
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22019:
URL: https://github.com/apache/doris/pull/22019#issuecomment-1644119367
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #22019: [improvement](auth)select priv for Nereids
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #22019:
URL: https://github.com/apache/doris/pull/22019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #22019: [improvement](auth)select priv for Nereids
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #22019:
URL: https://github.com/apache/doris/pull/22019#discussion_r1268884177
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/UserAuthentication.java:
##########
@@ -55,14 +56,16 @@ private Plan checkPermission(LogicalRelation relation, ConnectContext connectCon
}
if (relationsToCheck.contains(relation.getClass())) {
Review Comment:
do we need update relationsToCheck list?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/UserAuthentication.java:
##########
@@ -55,14 +56,16 @@ private Plan checkPermission(LogicalRelation relation, ConnectContext connectCon
}
if (relationsToCheck.contains(relation.getClass())) {
- String dbName =
- !relation.getQualifier().isEmpty() ? relation.getQualifier().get(0) : null;
- String tableName = relation.getTable().getName();
- if (!connectContext.getEnv().getAccessManager().checkTblPriv(connectContext, dbName,
+ TableIf table = relation.getTable();
Review Comment:
not all relation has table, so u need to check null here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #22019: [improvement](auth)select priv for Nereids
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22019:
URL: https://github.com/apache/doris/pull/22019#issuecomment-1644119210
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org