[GitHub] graceguo-supercat commented on a change in pull request #4833: [sqllab] Help sqllab forget query history

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #4833: [sqllab] Help sqllab forget query history
URL: https://github.com/apache/incubator-superset/pull/4833#discussion_r183250130
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
 ##########
 @@ -16,12 +17,23 @@ class QueryAutoRefresh extends React.PureComponent {
   componentWillUnmount() {
     this.stopTimer();
   }
+  timeoutOldQueries() {
 
 Review comment:
   This logic should not be in front-end (browser-side). 
   Query table knows each query started time. it doesn't need front-end sends ajax call to set query state. 
   when front-end ask a query's status, server side should first check the query's start time, if
   
   - longer than 6 hours old: set it timeout and return timeout state.
   - < 6 hours: return its current status.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services