You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/09 02:56:36 UTC
[PR] fix(struct): exclude optional word from runtime [hugegraph]
imbajin opened a new pull request, #3295:
URL: https://github.com/apache/hugegraph/pull/3295
## Purpose of the PR
Standard distributions bundled GPLv3-only `word:1.3` even when its optional analyzer was unused. They now omit that library and its unused runtime dependencies. Users can still install Word separately when explicitly selecting it.
## Main Changes
- Keep Word as a provided compile/test dependency and update the actual runtime/shipped inventory.
- Report a missing Word dependency with a configuration error that preserves the cause.
- Document the external GPLv3 library's download, installation and analyzer configuration.
## Verifying these changes
- [x] Need tests and can be verified as follows:
- Formatting, clean Java 17 reactor compilation, fresh Git source-archive builds and exact dependency collection passed.
- Struct and Server analyzer tests passed; real packages support standard analyzers without Word and English/Chinese Word segmentation after installing only its external JAR.
- Source-built and binary packages separately passed authenticated Server/Gremlin, Client CRUD, ordinary Loader import/readback, Tools query/backup and Hubble checks, with shutdown. Automated package checks passed; manual license review remains part of release verification.
## Does this PR potentially affect the following parts?
- [x] Dependencies
- [ ] Modify configurations
- [ ] The public API
- [x] Other affects: the optional Word analyzer requires a separately installed runtime library.
- [ ] Nope
## Documentation Status
- [ ] `Doc - TODO`
- [x] `Doc - Done`: `docs/BUILDING.md`.
- [ ] `Doc - No Need`
Related release validation: https://github.com/apache/hugegraph-doc/pull/512.
Related Toolchain SDK packaging: https://github.com/apache/hugegraph-toolchain/pull/794.
Validation uses unsigned local packages; real RC signatures and remote Maven staging remain separate gates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(struct): exclude optional word from runtime [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3295:
URL: https://github.com/apache/hugegraph/pull/3295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(struct): exclude optional word from runtime [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3295:
URL: https://github.com/apache/hugegraph/pull/3295#issuecomment-6073364981
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3295?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.91%. Comparing base ([`5039e5b`](https://app.codecov.io/gh/apache/hugegraph/commit/5039e5b67d26ea305b8509d3a414877749baaebb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83e1284`](https://app.codecov.io/gh/apache/hugegraph/commit/83e1284a3dcfc48668a52a4657a23a3efcfefd0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3295 +/- ##
=============================================
+ Coverage 41.87% 93.91% +52.03%
+ Complexity 6969 63 -6906
=============================================
Files 768 8 -760
Lines 66436 263 -66173
Branches 8831 21 -8810
=============================================
- Hits 27823 247 -27576
+ Misses 35468 8 -35460
+ Partials 3145 8 -3137
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3295?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(struct): exclude optional word from runtime [hugegraph]
Posted by "bitflicker64 (via GitHub)" <gi...@apache.org>.
bitflicker64 commented on code in PR #3295:
URL: https://github.com/apache/hugegraph/pull/3295#discussion_r4227375214
##########
hugegraph-struct/pom.xml:
##########
@@ -138,6 +138,8 @@
<groupId>org.apdplat</groupId>
<artifactId>word</artifactId>
<version>1.3</version>
+ <!-- External optional analyzer; compile/test it without shipping it. -->
+ <scope>provided</scope>
Review Comment:
Minor: With word in provided scope, this PR removes commons-pool2-2.0, jedis-2.5.1, lucene-backward-codecs-5.2.1, lucene-misc-5.2.1, lucene-suggest-5.2.1 and pinyin4j-2.5.0 from known-dependencies.txt, so the binary package no longer ships them. install-dist/release-docs/LICENSE still lists all six (lines 695, 697, 698, 702, 714 and 769), and install-dist/release-docs/licenses/ still holds LICENSE-commons-pool2-2.0.txt, LICENSE-jedis-2.5.1.txt, LICENSE-lucene-{backward-codecs,misc,suggest}-5.2.1.txt and LICENSE-pinyin4j-2.5.0.txt. That makes the release LICENSE disagree with the bundled jars, which release verification checks. Please remove those six LICENSE entries and their license text files in this PR, so the inventory and LICENSE change together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org