[jira] [Commented] (PIG-1890) Fix piggybank unit test TestAvroStorage

["Ken Goodhope (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041915#comment-13041915 ] 

Ken Goodhope commented on PIG-1890:
-----------------------------------

I need some clarification on the contract for POProject.getNext(Tuple).  Right now, if it receives a tuple with a single element, it extracts that element and attempts to cast it as a tuple and return it.  This breaks with any single element tuple that where the single element is not a tuple.  The code could be modified to not extract non-tuple elements.

> Fix piggybank unit test TestAvroStorage
> ---------------------------------------
>
>                 Key: PIG-1890
>                 URL: https://issues.apache.org/jira/browse/PIG-1890
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Jakob Homan
>             Fix For: 0.9.0
>
>         Attachments: PIG-1890-1.patch
>
>
> TestAvroStorage fail on trunk. There are two reasons:
> 1. After PIG-1680, we call LoadFunc.setLocation one more time.
> 2. The schema for AvroStorage seems to be wrong. For example, in first test case testArrayDefault, the schema for "in" is set to "PIG_WRAPPER: (FIELD: {PIG_WRAPPER: (ARRAY_ELEM: float)})". It seems PIG_WRAPPER is redundant. This issue is hidden until PIG-1188 checked in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira