You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:03:11 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
xiaoxiang781216 opened a new pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280
## Summary
Remove accidently in PR: https://github.com/apache/incubator-nuttx/pull/2243
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725254711
> > `__GLIBC__` is not a predefined macro. it's defined by system headers.
> > it canl be defined again by system headers included after __config.
> > IMO it's better to avoid checking `__GLIBC__` in libcxx.
>
> Yes, but it isn't avoidable if we want to use the toolchain library(libm). math.h provided by system bring in `__GLIBC__` macro. Undefine `__GLIBC__` could fix the most issue so far.
which `__GLIBC__` check in libcxx causes the issue with the toolchain libm?
i guess it's better to make it like `!defined(__NuttX__) && defined(__GLIBC__)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725252603
> `__GLIBC__`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725251420
> `__GLIBC__` is not a predefined macro. it's defined by system headers.
> it canl be defined again by system headers included after __config.
> IMO it's better to avoid checking `__GLIBC__` in libcxx.
Yes, but it isn't avoidable if we want to use the toolchain library(libm). match.h provided by system bring in __GLIBC__ macro. Undefine `__GLIBC__` could fix the most issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725238471
`__GLIBC__` is not a predefined macro. it's defined by system headers.
it canl be defined again by system headers included after __config.
IMO it's better to avoid checking `__GLIBC__` in libcxx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725416734
> > > `__GLIBC__` is not a predefined macro. it's defined by system headers.
> > > it canl be defined again by system headers included after __config.
> > > IMO it's better to avoid checking `__GLIBC__` in libcxx.
> >
> >
> > Yes, but it isn't avoidable if we want to use the toolchain library(libm). math.h provided by system bring in `__GLIBC__` macro. Undefine `__GLIBC__` could fix the most issue so far.
>
> which `__GLIBC__` check in libcxx causes the issue with the toolchain libm?
here: https://github.com/apache/incubator-nuttx/pull/2283/commits/85b64208a5e378819be83bade7873b6027bd1bf9
> i guess it's better to make it like `!defined(__NuttX__) && defined(__GLIBC__)`.
Ok, let's fix __GLIBC__ reference instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725253024
i closed this by mistake. sorry. i reopened it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725251420
> `__GLIBC__` is not a predefined macro. it's defined by system headers.
> it canl be defined again by system headers included after __config.
> IMO it's better to avoid checking `__GLIBC__` in libcxx.
Yes, but it isn't avoidable if we want to use the toolchain library(libm). math.h provided by system bring in `__GLIBC__` macro. Undefine `__GLIBC__` could fix the most issue so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt closed pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
yamt closed pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2280: libcxx: Undefine __GLIBC__ to avoid sim environment conflict with the host
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #2280:
URL: https://github.com/apache/incubator-nuttx/pull/2280#issuecomment-725251420
> `__GLIBC__` is not a predefined macro. it's defined by system headers.
> it canl be defined again by system headers included after __config.
> IMO it's better to avoid checking `__GLIBC__` in libcxx.
Yes, but it isn't avoidable if we want to use the toolchain library(libm). match.h provided by system bring in `__GLIBC__` macro. Undefine `__GLIBC__` could fix the most issue so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org