You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/14 20:32:46 UTC
[GitHub] [beam] KonradJanica commented on a change in pull request #16122: [BEAM-13345] [Playground] add resizable split view for output and source areas
KonradJanica commented on a change in pull request #16122:
URL: https://github.com/apache/beam/pull/16122#discussion_r769022333
##########
File path: playground/frontend/lib/components/split_view/split_view.dart
##########
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+import 'package:flutter_svg/flutter_svg.dart';
+import 'package:playground/config/theme.dart';
+import 'package:playground/constants/assets.dart';
+
+enum SplitViewDirection {
+ vertical,
+ horizontal,
+}
+
+const minRatio = 0.3;
+const maxRatio = 0.7;
+const defaultRatio = 0.5;
+
+class SplitView extends StatefulWidget {
+ final Widget first;
+ final Widget second;
+ final double dividerSize;
+ final SplitViewDirection direction;
+ final double ratio;
+
+ const SplitView({
+ Key? key,
+ required this.first,
+ required this.second,
+ required this.dividerSize,
+ required this.direction,
+ this.ratio = defaultRatio,
+ }) : super(key: key);
+
+ @override
+ _SplitViewState createState() => _SplitViewState();
+}
+
+class _SplitViewState extends State<SplitView> {
+ //from minRatio to maxRatio
+ double _ratio = defaultRatio;
+ double? _maxSize;
+
+ get _sizeFirst => _ratio * _maxSize!;
+
+ get _sizeSecond => (1 - _ratio) * _maxSize!;
+
+ get _isHorizontal => widget.direction == SplitViewDirection.horizontal;
+
+ get _isVertical => widget.direction == SplitViewDirection.vertical;
+
+ @override
+ void initState() {
+ super.initState();
+ _ratio = widget.ratio;
+ }
+
+ @override
+ Widget build(BuildContext widgetContext) {
+ return LayoutBuilder(builder: (context, BoxConstraints constraints) {
+ _updateMaxSize(constraints);
+ return _isHorizontal
+ ? _buildHorizontalLayout(context, constraints)
+ : _buildVerticalLayout(context, constraints);
+ });
+ }
+
+ _buildHorizontalLayout(BuildContext context, BoxConstraints constraints) {
+ return SizedBox(
+ width: constraints.maxWidth,
+ child: Row(
+ children: <Widget>[
+ SizedBox(
+ width: _sizeFirst,
+ child: widget.first,
+ ),
+ _buildSeparator(context),
+ SizedBox(
+ width: _sizeSecond,
+ child: widget.second,
+ ),
+ ],
+ ),
+ );
+ }
+
+ Widget _buildVerticalLayout(
+ BuildContext context, BoxConstraints constraints) {
+ return SizedBox(
+ height: constraints.maxHeight,
+ child: Column(
+ children: <Widget>[
+ SizedBox(
+ height: _sizeFirst,
+ child: widget.first,
+ ),
+ _buildSeparator(context),
+ SizedBox(
+ height: _sizeSecond,
+ child: widget.second,
+ ),
+ ],
+ ),
+ );
+ }
+
+ Widget _buildSeparator(BuildContext context) {
+ return MouseRegion(
+ cursor: _isHorizontal
+ ? SystemMouseCursors.resizeLeftRight
+ : SystemMouseCursors.resizeUpDown,
+ child: GestureDetector(
+ behavior: HitTestBehavior.translucent,
+ child: Container(
+ width: _isHorizontal ? widget.dividerSize : double.infinity,
+ height: _isVertical ? widget.dividerSize : double.infinity,
+ color: ThemeColors.of(context).greyColor,
+ child: Center(
+ child: SvgPicture.asset(_isHorizontal
+ ? kDragHorizontalIconAsset
+ : kDragVerticalIconAsset),
+ )),
+ onPanUpdate: (DragUpdateDetails details) {
+ setState(() {
+ _updateRatio(details);
+ });
+ },
+ ),
+ );
+ }
+
+ void _updateRatio(DragUpdateDetails details) {
+ if (_isHorizontal) {
+ _ratio += details.delta.dx / _maxSize!;
Review comment:
Please prevent divide by zero errors here and a few lines below.
##########
File path: playground/frontend/lib/components/split_view/split_view.dart
##########
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+import 'package:flutter_svg/flutter_svg.dart';
+import 'package:playground/config/theme.dart';
+import 'package:playground/constants/assets.dart';
+
+enum SplitViewDirection {
+ vertical,
+ horizontal,
+}
+
+const minRatio = 0.3;
+const maxRatio = 0.7;
+const defaultRatio = 0.5;
+
+class SplitView extends StatefulWidget {
+ final Widget first;
+ final Widget second;
+ final double dividerSize;
+ final SplitViewDirection direction;
+ final double ratio;
+
+ const SplitView({
+ Key? key,
+ required this.first,
+ required this.second,
+ required this.dividerSize,
+ required this.direction,
+ this.ratio = defaultRatio,
+ }) : super(key: key);
+
+ @override
+ _SplitViewState createState() => _SplitViewState();
+}
+
+class _SplitViewState extends State<SplitView> {
+ //from minRatio to maxRatio
+ double _ratio = defaultRatio;
+ double? _maxSize;
+
+ get _sizeFirst => _ratio * _maxSize!;
+
+ get _sizeSecond => (1 - _ratio) * _maxSize!;
+
+ get _isHorizontal => widget.direction == SplitViewDirection.horizontal;
+
+ get _isVertical => widget.direction == SplitViewDirection.vertical;
+
+ @override
+ void initState() {
+ super.initState();
+ _ratio = widget.ratio;
+ }
+
+ @override
+ Widget build(BuildContext widgetContext) {
+ return LayoutBuilder(builder: (context, BoxConstraints constraints) {
+ _updateMaxSize(constraints);
+ return _isHorizontal
+ ? _buildHorizontalLayout(context, constraints)
+ : _buildVerticalLayout(context, constraints);
+ });
+ }
+
+ _buildHorizontalLayout(BuildContext context, BoxConstraints constraints) {
+ return SizedBox(
+ width: constraints.maxWidth,
+ child: Row(
+ children: <Widget>[
+ SizedBox(
+ width: _sizeFirst,
+ child: widget.first,
+ ),
+ _buildSeparator(context),
+ SizedBox(
+ width: _sizeSecond,
+ child: widget.second,
+ ),
+ ],
+ ),
+ );
+ }
+
+ Widget _buildVerticalLayout(
+ BuildContext context, BoxConstraints constraints) {
+ return SizedBox(
+ height: constraints.maxHeight,
+ child: Column(
+ children: <Widget>[
+ SizedBox(
+ height: _sizeFirst,
+ child: widget.first,
+ ),
+ _buildSeparator(context),
+ SizedBox(
+ height: _sizeSecond,
+ child: widget.second,
+ ),
+ ],
+ ),
+ );
+ }
+
+ Widget _buildSeparator(BuildContext context) {
+ return MouseRegion(
+ cursor: _isHorizontal
+ ? SystemMouseCursors.resizeLeftRight
+ : SystemMouseCursors.resizeUpDown,
+ child: GestureDetector(
+ behavior: HitTestBehavior.translucent,
+ child: Container(
+ width: _isHorizontal ? widget.dividerSize : double.infinity,
+ height: _isVertical ? widget.dividerSize : double.infinity,
+ color: ThemeColors.of(context).greyColor,
+ child: Center(
+ child: SvgPicture.asset(_isHorizontal
+ ? kDragHorizontalIconAsset
+ : kDragVerticalIconAsset),
+ )),
+ onPanUpdate: (DragUpdateDetails details) {
+ setState(() {
+ _updateRatio(details);
+ });
+ },
+ ),
+ );
+ }
+
+ void _updateRatio(DragUpdateDetails details) {
+ if (_isHorizontal) {
+ _ratio += details.delta.dx / _maxSize!;
+ } else {
+ _ratio += details.delta.dy / _maxSize!;
+ }
+ _checkRatioSafe();
+ }
+
+ void _checkRatioSafe() {
+ if (_ratio > maxRatio) {
+ _ratio = maxRatio;
+ }
+ if (_ratio < minRatio) {
+ _ratio = minRatio;
+ }
+ }
+
+ void _updateMaxSize(BoxConstraints constraints) {
+ _calculateMaxSize(
+ _isHorizontal ? constraints.maxWidth : constraints.maxHeight);
+ }
+
+ void _calculateMaxSize(double maxSize) {
+ _maxSize ??= maxSize - widget.dividerSize;
Review comment:
This line is not needed, `maxSize` is a double so it cannot be null. The check underneath will always catch null values.
##########
File path: playground/frontend/lib/components/split_view/split_view.dart
##########
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+import 'package:flutter_svg/flutter_svg.dart';
+import 'package:playground/config/theme.dart';
+import 'package:playground/constants/assets.dart';
+
+enum SplitViewDirection {
+ vertical,
+ horizontal,
+}
+
+const minRatio = 0.3;
+const maxRatio = 0.7;
+const defaultRatio = 0.5;
+
+class SplitView extends StatefulWidget {
+ final Widget first;
+ final Widget second;
+ final double dividerSize;
+ final SplitViewDirection direction;
+ final double ratio;
+
+ const SplitView({
+ Key? key,
+ required this.first,
+ required this.second,
+ required this.dividerSize,
+ required this.direction,
+ this.ratio = defaultRatio,
+ }) : super(key: key);
+
+ @override
+ _SplitViewState createState() => _SplitViewState();
+}
+
+class _SplitViewState extends State<SplitView> {
+ //from minRatio to maxRatio
+ double _ratio = defaultRatio;
+ double? _maxSize;
Review comment:
Using a nullable type here seem like a code smell. Perhaps initialize the _maxSize to 0 and then remove the exclamation marks. The exclamation marks are most likely converting the value to a zero valued non-nullable int anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org