[GitHub] [ozone] rakeshadr commented on a diff in pull request #3477: HDDS-6683. Refactor OM server bucket layout configuration usage

[GitBox <gi...@apache.org>]

rakeshadr commented on code in PR #3477:
URL: https://github.com/apache/ozone/pull/3477#discussion_r888853018


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -152,8 +151,12 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
     OMResponse.Builder omResponse = OmResponseUtil.getOMResponseBuilder(
         getOmRequest());
     OmBucketInfo omBucketInfo = null;
-    if (bucketInfo.getBucketLayout() == null || bucketInfo.getBucketLayout()
-        .equals(BucketLayoutProto.LEGACY)) {
+
+    // If the user has set a value, bucketInfo.hasBucketLayout() would be true,

Review Comment:
   Please modify the comment to
   ```
   
       // bucketInfo.hasBucketLayout() would be true when user sets bucket layout.
       // Now, OM will create bucket with the user specified bucket layout.
       // When the value is not specified by the user, OM will use the
       // "ozone.default.bucket.layout" configured value.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org