You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/06/14 09:51:20 UTC

[jira] [Commented] (WICKET-5235) Button silently ignores MissingResourceException

    [ https://issues.apache.org/jira/browse/WICKET-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683174#comment-13683174 ] 

Sven Meier commented on WICKET-5235:
------------------------------------

Digging into the old SF svn it seems that the try-catch was introduced first [1] to make it possible to use a button inside a CompoundPropertyModel. Later on this case was handled additionally by overriding #initModel().

So it seems to me, that the try-catch is obsolete.

[1] http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java?r1=457657&r2=457679&diff_format=h
[2] http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Button.java?r1=459746&r2=459762&diff_format=h
                
> Button silently ignores MissingResourceException
> ------------------------------------------------
>
>                 Key: WICKET-5235
>                 URL: https://issues.apache.org/jira/browse/WICKET-5235
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.8.0
>            Reporter: Markus Pulkkinen
>            Priority: Minor
>
> When a Button is rendered with model that tries to load a resource that is missing
> and ResourceSettings.throwExceptionOnMissingResource = true, the button catches and silently ignores the MissingResourceException in onComponentTag(), which is not nice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira