You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/22 02:56:38 UTC
[GitHub] codecov-io commented on issue #3535: Optimize all filter predicates
by adding isAlwaysTrue()
codecov-io commented on issue #3535: Optimize all filter predicates by adding isAlwaysTrue()
URL: https://github.com/apache/incubator-pinot/pull/3535#issuecomment-440897833
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=h1) Report
> Merging [#3535](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/79f83e9a3bd9f017f36f20131a90b850bef84983?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `92.92%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3535 +/- ##
============================================
- Coverage 70.89% 70.71% -0.19%
Complexity 4 4
============================================
Files 998 997 -1
Lines 45669 45696 +27
Branches 6108 6124 +16
============================================
- Hits 32379 32315 -64
- Misses 11176 11252 +76
- Partials 2114 2129 +15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ore/operator/filter/BitmapBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9CaXRtYXBCYXNlZEZpbHRlck9wZXJhdG9yLmphdmE=) | `87.87% <ø> (+2.58%)` | `0 <0> (ø)` | :arrow_down: |
| [...predicate/RegexpLikePredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvUmVnZXhwTGlrZVByZWRpY2F0ZUV2YWx1YXRvckZhY3RvcnkuamF2YQ==) | `29.16% <ø> (-2.84%)` | `0 <0> (ø)` | |
| [...filter/SortedInvertedIndexBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9Tb3J0ZWRJbnZlcnRlZEluZGV4QmFzZWRGaWx0ZXJPcGVyYXRvci5qYXZh) | `79.59% <ø> (-6.41%)` | `0 <0> (ø)` | |
| [.../core/operator/filter/ScanBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9TY2FuQmFzZWRGaWx0ZXJPcGVyYXRvci5qYXZh) | `90% <ø> (-0.48%)` | `0 <0> (ø)` | |
| [.../predicate/NotEqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvTm90RXF1YWxzUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `85.24% <100%> (-6.28%)` | `0 <0> (ø)` | |
| [...edicate/BaseDictionaryBasedPredicateEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvQmFzZURpY3Rpb25hcnlCYXNlZFByZWRpY2F0ZUV2YWx1YXRvci5qYXZh) | `59.09% <100%> (+4.09%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/pinot/core/operator/filter/OrFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9PckZpbHRlck9wZXJhdG9yLmphdmE=) | `88.88% <100%> (+24.6%)` | `0 <0> (ø)` | :arrow_down: |
| [...ter/predicate/EqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvRXF1YWxzUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `91.48% <100%> (+0.37%)` | `0 <0> (ø)` | :arrow_down: |
| [...pinot/core/operator/filter/BaseFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9CYXNlRmlsdGVyT3BlcmF0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../pinot/core/operator/filter/AndFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9BbmRGaWx0ZXJPcGVyYXRvci5qYXZh) | `88.88% <100%> (+10.31%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=footer). Last update [79f83e9...63b7b4d](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org