You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/05 15:06:44 UTC
[commons-fileupload] 01/03: Refactor test
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit fbddc729ac97a88db4eec65b8ec6ee7ea20b7fe5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jun 5 08:50:04 2023 -0400
Refactor test
---
.../fileupload2/jakarta/JakartaServletFileUploadTest.java | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/commons-fileupload2-jakarta/src/test/java/org/apache/commons/fileupload2/jakarta/JakartaServletFileUploadTest.java b/commons-fileupload2-jakarta/src/test/java/org/apache/commons/fileupload2/jakarta/JakartaServletFileUploadTest.java
index d1b7af3..ba0c47c 100644
--- a/commons-fileupload2-jakarta/src/test/java/org/apache/commons/fileupload2/jakarta/JakartaServletFileUploadTest.java
+++ b/commons-fileupload2-jakarta/src/test/java/org/apache/commons/fileupload2/jakarta/JakartaServletFileUploadTest.java
@@ -26,6 +26,7 @@ import java.util.Map;
import org.apache.commons.fileupload2.AbstractFileUploadTest;
import org.apache.commons.fileupload2.Constants;
import org.apache.commons.fileupload2.FileItem;
+import org.apache.commons.fileupload2.FileUploadException;
import org.apache.commons.fileupload2.disk.DiskFileItemFactory;
import org.junit.jupiter.api.Test;
@@ -37,7 +38,11 @@ import jakarta.servlet.http.HttpServletRequest;
* @see AbstractFileUploadTest
* @since 1.4
*/
-public class JakartaServletFileUploadTest {
+public class JakartaServletFileUploadTest extends AbstractFileUploadTest<JakartaServletFileUpload> {
+
+ public JakartaServletFileUploadTest() {
+ super(new JakartaServletFileUpload(new DiskFileItemFactory()));
+ }
@Test
public void parseImpliedUtf8() throws Exception {
@@ -102,4 +107,10 @@ public class JakartaServletFileUploadTest {
assertTrue(mappedParameters.containsKey("multi"));
assertEquals(2, mappedParameters.get("multi").size());
}
+
+ @Override
+ public List<FileItem> parseUpload(final JakartaServletFileUpload upload, final byte[] bytes, final String contentType) throws FileUploadException {
+ final HttpServletRequest request = new JakartaMockHttpServletRequest(bytes, contentType);
+ return upload.parseRequest(new JakartaServletRequestContext(request));
+ }
}