You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/01/29 08:39:27 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23801: Replace `CountEncryptRuleResultSet` with `CountEncryptRuleExecutor`
Qianyi951015 opened a new pull request, #23801:
URL: https://github.com/apache/shardingsphere/pull/23801
For #23772.
Changes proposed in this pull request:
- Replace `CountEncryptRuleResultSet` with `CountEncryptRuleExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23801: Replace `CountEncryptRuleResultSet` with `CountEncryptRuleExecutor`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23801:
URL: https://github.com/apache/shardingsphere/pull/23801#issuecomment-1407605999
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23801?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23801](https://codecov.io/gh/apache/shardingsphere/pull/23801?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da24c01) into [master](https://codecov.io/gh/apache/shardingsphere/commit/88111c7272a35dd89627354dc8f257d1c066db6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88111c7) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23801 +/- ##
=========================================
Coverage 49.77% 49.77%
Complexity 2471 2471
=========================================
Files 4108 4108
Lines 58295 58296 +1
Branches 10114 10115 +1
=========================================
+ Hits 29015 29017 +2
+ Misses 26789 26788 -1
Partials 2491 2491
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...istsql/handler/query/CountEncryptRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/23801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L0NvdW50RW5jcnlwdFJ1bGVFeGVjdXRvci5qYXZh) | `81.81% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23801: Replace `CountEncryptRuleResultSet` with `CountEncryptRuleExecutor`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #23801:
URL: https://github.com/apache/shardingsphere/pull/23801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org