[GitHub] [james-project] Arsnael commented on a change in pull request #484: JAMES-2886 Fix collection handling for PropertiesProvider

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #484:
URL: https://github.com/apache/james-project/pull/484#discussion_r647079052



##########
File path: server/container/guice/configuration/src/test/java/org/apache/james/utils/PropertiesProviderTest.java
##########
@@ -95,4 +107,16 @@ void getListShouldReturnEmptyListWhenKeyNotFound() throws Exception {
         assertThat(testee.getConfiguration("a").getList("notExistKey"))
             .isEmpty();
     }
+
+    @Test
+    void getListShouldReturnEmptyListWhenKeyHasNoValue() throws Exception {
+        assertThat(testee.getConfiguration("a").getList("thisIsEmpty"))
+            .isEmpty();
+    }
+
+    @Test
+    void getArrayStringShouldReturnEmptyListWhenKeyHasNoValue() throws Exception {
+        assertThat(testee.getConfiguration("a").getList("thisIsEmpty"))

Review comment:
       ```suggestion
           assertThat(testee.getConfiguration("a").getStringArray("thisIsEmpty"))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org