You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/12/14 17:01:40 UTC

[GitHub] andrzej-kaczmarek commented on a change in pull request #1559: [Do Not Merge] - Change HAL I2C driver to use TWIM+EasyDMA

andrzej-kaczmarek commented on a change in pull request #1559: [Do Not Merge] - Change HAL I2C driver to use TWIM+EasyDMA
URL: https://github.com/apache/mynewt-core/pull/1559#discussion_r241821473
 
 

 ##########
 File path: hw/hal/include/hal/hal_i2c.h
 ##########
 @@ -219,6 +229,9 @@ int hal_i2c_master_read(uint8_t i2c_num, struct hal_i2c_master_data *pdata,
  */
 int hal_i2c_master_probe(uint8_t i2c_num, uint8_t address,
                          uint32_t timeout);
+int
+hal_i2c_master_write_read(uint8_t i2c_num, struct hal_i2c_master_data *pdata, uint32_t timo);
 
 Review comment:
   I don't think extending HAL is necessary here. are there any problems with using write+read as befure?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services