You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/06/11 12:58:42 UTC
[jira] [Created] (CAMEL-5355) camel-sql - Should support % sign in
query
Claus Ibsen created CAMEL-5355:
----------------------------------
Summary: camel-sql - Should support % sign in query
Key: CAMEL-5355
URL: https://issues.apache.org/jira/browse/CAMEL-5355
Project: Camel
Issue Type: Bug
Components: camel-sql
Affects Versions: 2.9.2, 2.8.5
Reporter: Claus Ibsen
Assignee: Claus Ibsen
Priority: Minor
Fix For: 2.8.6, 2.9.3, 2.10.0
See nabble
We should look into supporting the % sign in the sql component.
It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
We should also consider adding an option to refer to a SQL that is enlisted in the registry.
Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5355) camel-sql - Should support % sign
in query
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294473#comment-13294473 ]
Claus Ibsen commented on CAMEL-5355:
------------------------------------
I added a link to CAMEL-5357 as that fixes this issue, by allowing end users to use the decimal encoded value of %25 to indicate the % sign, accordingly to the uri encoding rules.
At first I did not want to backport this to the previous branches (eg 2.9 and 2.8), without discussing on @dev.
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5355) camel-sql - Should support % sign in
query
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-5355:
-------------------------------
Fix Version/s: (was: 2.8.6)
(was: 2.9.3)
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5355) camel-sql - Should support % sign
in query
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292756#comment-13292756 ]
Claus Ibsen commented on CAMEL-5355:
------------------------------------
CAMEL-4425 broke this, as it changed UnsafeUriCharactersEncoder to exclude the % sign.
The % sign should be percent encoded, if you want to use it as is, eg % should be %25 to indicate the % sign itself.
http://en.wikipedia.org/wiki/Url_encode
The % sign is otherwise used to escape values, such as space, becomes %20.
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.6, 2.9.3, 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5355) camel-sql - Should support % sign
in query
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292803#comment-13292803 ]
Hadrian Zbarcea commented on CAMEL-5355:
----------------------------------------
URIs that configure endpoints should be valid URIs as defined by [RFC-2396|http://www.ietf.org/rfc/rfc2396.txt] or stop claiming that Camel uses URIs. Tools expect that and many components are unusable for that matter. Maybe we should have a serious discussion on dev@ about that because this issues comes back over and over again.
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.6, 2.9.3, 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5355) camel-sql - Should support % sign in
query
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-5355.
--------------------------------
Resolution: Fixed
The % sign is now supported if specified as %25 which is according to URI encoding rules.
Discussion opened on @dev
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5355) camel-sql - Should support % sign
in query
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294465#comment-13294465 ]
Hadrian Zbarcea commented on CAMEL-5355:
----------------------------------------
I am not sure if this issue should be marked as fixed only in 2.10. As only tests were added, I'd say that camel works as designed in the already released 2.9.2 and 2.8.5, right?
> camel-sql - Should support % sign in query
> ------------------------------------------
>
> Key: CAMEL-5355
> URL: https://issues.apache.org/jira/browse/CAMEL-5355
> Project: Camel
> Issue Type: Bug
> Components: camel-sql
> Affects Versions: 2.8.5, 2.9.2
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.10.0
>
>
> See nabble
> We should look into supporting the % sign in the sql component.
> It should possible be less strict in uri validation as people can enter SQL queries. And to make it easy, they should just be able to dump in the SQL as is.
> We should also consider adding an option to refer to a SQL that is enlisted in the registry.
> Also people should be able to externalize their SQL in a .properties file and have Camel lookup that using the {{ }} notation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira