You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/03 08:53:47 UTC

[GitHub] [arrow] pitrou commented on pull request #7334: ARROW-5082: [Python] Substantially reduce Python wheel package and install size

pitrou commented on pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#issuecomment-638059015


   > I added function that tries to create the necessary symlinks when you call pyarrow.get_library_dirs()
   
   It's a bad idea to add side effects to a simple inquiry function. This should IMHO be in a separate function (e.g. `create_library_symlinks`).
   
   > I don't think we need to ship the tests in the wheels.
   
   I'd like to keep them. It's helpful to test if an installation works correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org