[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823#discussion_r975966769


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -56,45 +55,54 @@ public void open() {
 
     @Override
     public void run() {
-        pendingSplit = getHiveFileSplit();
-        assignSplit(context.registeredReaders());
+        // do nothing
     }
 
-    private Set<FileSourceSplit> getHiveFileSplit() {
-        Set<FileSourceSplit> hiveSourceSplits = new HashSet<>();
-        filePaths.forEach(k -> hiveSourceSplits.add(new FileSourceSplit(k)));
-        return hiveSourceSplits;
-
+    private Set<FileSourceSplit> getFileSplit() {
+        Set<FileSourceSplit> fileSourceSplits = new HashSet<>();
+        filePaths.forEach(k -> fileSourceSplits.add(new FileSourceSplit(k)));

Review Comment:
   Is `filePaths` possible to be null? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org